GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106368: Increase Argument Clinic test coverage by erlend-aasland · Pull Request #107582 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 3, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add tests for DSL parser state machine and docstring formatting

  • Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-106368: Increase Argument Clinic test coverage
66d6824 
Add tests for DSL parser state machine and docstring formatting
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner August 3, 2023 08:57
@erlend-aasland erlend-aasland added the skip news label Aug 3, 2023
@erlend-aasland
erlend-aasland requested a review from sobolevn August 3, 2023 08:57
@bedevere-bot bedevere-bot added the awaiting core review label Aug 3, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 3, 2023
Increase Argument Clinic test coverage #106368
Closed
@erlend-aasland

erlend-aasland commented Aug 3, 2023

Copy link
Copy Markdown
Contributor Author

Increases coverage from 91% to 92%. Catches most of the weird branches in the state machine. The remaining branches are hard, if not impossible, to trigger. There are multiple layers of conditions and exception handling; I'd not be surprised if most of the remaining branches are actually unreachable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes Aug 3, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .py tests LGTM! Just one question:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 3, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 3, 2023 09:32
@erlend-aasland

erlend-aasland commented Aug 3, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review!
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland linked an issue Aug 3, 2023 that may be closed by this pull request
Increase Argument Clinic test coverage #106368
Closed
@erlend-aasland
erlend-aasland merged commit a73daf5 into python:main Aug 3, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 3, 2023
@erlend-aasland
erlend-aasland deleted the clinic/sm-and-ds-coverage branch August 3, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@sobolevn sobolevn Awaiting requested review from sobolevn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Increase Argument Clinic test coverage

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.