GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106368: Argument clinic: add tests for more failure paths by AlexWaygood · Pull Request #107731 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Aug 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

And fix a minor bug I discovered along the way.

This gets us up to 95% coverage.

  • Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
Argument clinic: add tests for more failure paths
8400b67
@AlexWaygood AlexWaygood added the skip news label Aug 7, 2023
@AlexWaygood
AlexWaygood requested a review from erlend-aasland as a code owner August 7, 2023 17:24
@bedevere-bot bedevere-bot added the awaiting core review label Aug 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 7, 2023
Increase Argument Clinic test coverage #106368
Closed
AlexWaygood
AlexWaygood commented Aug 7, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Aug 8, 2023
View reviewed changes
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Aug 8, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. BTW, can you remove test_parameters_required_after_depr_star (line 1471)? I introduced an equal named, but slightly better test in #95151). Makes sense to bake it into this PR, rather than creating a new PR specifically for that removal.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 8, 2023
@AlexWaygood
Merge branch 'main' into clinic-more-coverage
a93ce1a
@AlexWaygood

AlexWaygood commented Aug 8, 2023

Copy link
Copy Markdown
Member Author

Looks good. BTW, can you remove test_parameters_required_after_depr_star (line 1471)? I introduced an equal named, but slightly better test in #95151). Makes sense to bake it into this PR, rather than creating a new PR specifically for that removal.

Hmm, the new test that you added fails if I remove test_parameters_required_after_depr_star on line 1471. The new test method that you added is currently never run, because it is immediately overridden by the old test method later on in the class definition before unittest even tries to run any of the tests.

We really need to start running pyflakes on Tools/clinic/ and test_clinic.py in CI :)
erlend-aasland reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Well, remove the new test, then 😄
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Remove redundant tests
bec0b72
@AlexWaygood
AlexWaygood enabled auto-merge (squash) August 8, 2023 11:15
erlend-aasland
erlend-aasland approved these changes Aug 8, 2023
View reviewed changes
@AlexWaygood
AlexWaygood merged commit 7c5153d into python:main Aug 8, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.