GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-56166: Deprecate passing counts and maxsplit via position in re by hauntsaninja · Pull Request #107767 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Aug 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Patch authored by @serhiy-storchaka

  • Issue: re.sub confusion between count and flags args #56166

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Zac-HD reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@hauntsaninja
pythongh-56166: Deprecate passing counts and flags via position in re
6cabb45 
Patch authored by @serhiy-storchaka
@bedevere-bot bedevere-bot mentioned this pull request Aug 8, 2023
re.sub confusion between count and flags args #56166
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 8, 2023
@hauntsaninja

hauntsaninja commented Aug 8, 2023

Copy link
Copy Markdown
Contributor Author

This is a very common mistake, see #99918 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja hauntsaninja changed the title gh-56166: Deprecate passing counts and flags via position in re gh-56166: Deprecate passing counts and maxsplit via position in re Aug 8, 2023
blurb-it Bot and others added 3 commits August 8, 2023 08:46
@blurb-it
📜🤖 Added by blurb_it.
8469cc2
@hauntsaninja
docs
fe60982
@hauntsaninja
idle
c2d8f1c
@hauntsaninja
hauntsaninja requested a review from terryjreedy as a code owner August 8, 2023 09:05
@hauntsaninja hauntsaninja mentioned this pull request Aug 8, 2023
Fix incorrect use of re function in tests pypa/pip#12213
Merged
@serhiy-storchaka
serhiy-storchaka self-requested a review August 8, 2023 12:05
@serhiy-storchaka

serhiy-storchaka commented Aug 8, 2023

Copy link
Copy Markdown
Member

Thank you for your PR @hauntsaninja, but there is a different solution to a problem with signature. Also, these parameters are not keyword-only yet, so they should not be documented so. Instead the deprecation of passing the corresponding arguments positionally should be documented. I created a different PR #107778.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja hauntsaninja closed this Aug 8, 2023
@hauntsaninja
hauntsaninja deleted the gh-56166 branch August 8, 2023 17:35
@terryjreedy

terryjreedy commented Aug 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since the other patch passed all checks, I am assuming that inspect.signature will continue to display '0' rather than'_zero_sentinal', so that the IDLE tests should continue as is.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hauntsaninja @serhiy-storchaka @terryjreedy @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.