GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105481: split opcode_ids.h out of opcode.h so that it can be generated separately by iritkatriel · Pull Request #107866 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Aug 11, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Generate opcode metadata from bytecodes.c instead of opcode.py #105481

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 5 commits August 11, 2023 11:52
@iritkatriel
separate code for generating the different output files
7706d77
@iritkatriel
rename variables
88370df
@iritkatriel
pythongh-105481: split opcode_ids.h out of opcode.h so that it can be…
bf657bf 
… generated separately
@iritkatriel
rename variable
baf810e
@iritkatriel
mark opcode_ids.h as generated
696da11
@bedevere-bot bedevere-bot mentioned this pull request Aug 11, 2023
Generate opcode metadata from bytecodes.c instead of opcode.py #105481
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 11, 2023
@iritkatriel
windows makefile
b6074fc
@iritkatriel
iritkatriel requested a review from a team as a code owner August 11, 2023 13:57
@iritkatriel iritkatriel added the skip news label Aug 11, 2023
@ambv

ambv commented Aug 11, 2023

Copy link
Copy Markdown
Contributor

Closing and re-opening to retrigger CLA checks. Sorry for the noise.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Aug 11, 2023
@ambv ambv reopened this Aug 11, 2023
markshannon
markshannon approved these changes Aug 11, 2023
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 11, 2023
@iritkatriel
iritkatriel merged commit caa41a4 into python:main Aug 11, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 11, 2023
@iritkatriel
iritkatriel deleted the opcode_h branch November 13, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @ambv @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.