GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93057: Use 'sqlite3' as module name for clinic input in Modules/_sqlite/connection.c by erlend-aasland · Pull Request #107879 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 11, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This change has no impact on behaviour. It is needed only for Argument
Clinic to produce nicer deprecation messages when we get to deprecate
positional use of optional parameters to sqlite3.connect().

  • Issue: Make optional parameters of sqlite3.connect() keyword-only #93057

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
pythongh-93057: Use 'sqlite3' as module name for clinic input in Modu…
671b940
…les/_sqlite/connection.c

This change has no impact on behaviour. It is needed only for Argument
Clinic to produce nicer deprecation messages when we get to deprecate
positional use of optional parameters to sqlite3.connect().
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner August 11, 2023 21:10
@erlend-aasland erlend-aasland added the skip news label Aug 11, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 11, 2023
Make optional parameters of sqlite3.connect() keyword-only #93057
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 11, 2023
@erlend-aasland

erlend-aasland commented Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

We only need to change connection.c; there is no need to change all files in Modules/_sqlite.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka August 11, 2023 21:11
@erlend-aasland
Regen
0dc266e
@erlend-aasland erlend-aasland mentioned this pull request Aug 14, 2023
gh-93057: Deprecate positional use of optional sqlite3.connect() params #107948
Merged
@erlend-aasland

erlend-aasland commented Aug 15, 2023

Copy link
Copy Markdown
Contributor Author

After de7e87c, I don't think this is needed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland closed this Aug 15, 2023
@erlend-aasland
erlend-aasland deleted the sqlite/clinic-module-alt branch August 15, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.