GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107211: Fix select extension build on Solaris by vstinner · Pull Request #108012 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 16, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Export the internal _Py_open() function for Solaris: the select extension uses it in its newDevPollObject() function.

  • Issue: C API: No longer export internal C API functions #107211

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kulikjak reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@vstinner vstinner added the skip news label Aug 16, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
C API: No longer export internal C API functions #107211
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 16, 2023
@vstinner
vstinner force-pushed the export_py_open branch from 30ce6fd to 87a1a21 Compare August 16, 2023 11:56
@vstinner

vstinner commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

@kulikjak: Can you please check if this change fix your build issue? ref: #107211 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-107211: Fix select extension build on Solaris
dbc8633 
Export the internal _Py_open() and _Py_write() functions for Solaris:
the select shared extension uses them.
@vstinner
vstinner force-pushed the export_py_open branch from 87a1a21 to dbc8633 Compare August 16, 2023 11:58
kulikjak
kulikjak approved these changes Aug 16, 2023
View reviewed changes

@kulikjak kulikjak left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I tested it and the issues are gone.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit fb8fe37 into python:main Aug 16, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 16, 2023
@vstinner
vstinner deleted the export_py_open branch August 16, 2023 20:26
@vstinner

vstinner commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

You're welcome. It seems like we have no Solaris buildbot anymore. I'm fine with you reporting issues manually :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kulikjak

kulikjak commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

Thank you.

As for the buildbot worker, there is technically a Solaris one I am maintaining, but sadly it's red all the time as there are some Solaris-specific changes that would need to be merged first. I created PRs for most of them some time ago, but they were not merged yet, and ATM they will probably need some rebasing and possibly minor updates to make them mergeable again.

Our internal buildbot is green/yellow most of the time, so it's definitely possible. I will look into it again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kulikjak kulikjak kulikjak approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @kulikjak @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.