GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-92584: Remove distutils mentions from ``importlib.metadata`` docs by AA-Turner · Pull Request #108026 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 16, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

eps.groups returns a set, so I've also changed the return type.

A

  • Issue: PEP 632: Remove the distutils package (Python 3.12) #92584

📚 Documentation preview 📚: https://cpython-previews--108026.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AA-Turner
Remove distutils from importlib.metadata
59c36c7
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes labels Aug 16, 2023
@AA-Turner
AA-Turner requested a review from jaraco August 16, 2023 14:23
@AA-Turner
AA-Turner requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners August 16, 2023 14:23
@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
PEP 632: Remove the distutils package (Python 3.12) #92584
Closed
@bedevere-bot bedevere-bot added the awaiting review label Aug 16, 2023
@AlexWaygood AlexWaygood changed the title GH-92584: Remove distutils from importlib.metadata GH-92584: Remove distutils mentions from importlib.metadata docs Aug 16, 2023
brettcannon
brettcannon approved these changes Aug 16, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 16, 2023
@jaraco jaraco self-assigned this Aug 17, 2023
jaraco
jaraco reviewed Aug 17, 2023
View reviewed changes

@jaraco jaraco left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib, but I'm reluctant to accept this change for a few reasons.

First, these docs changes originate in the importlib_metadata project, so probably should be contributed there first. They get synced into CPython as a matter of course, but contributing here first leads to conflicts and is more difficult to backport.

Second, the distutils.commands entry point is just as viable as console_scripts. Both are still actively supported by Setuptools, even while distutils is removed from the stdlib. There are no plans currently to even deprecate distutils.commands, so the value here is small.

Given my concerns with the changes, I propose instead to open an issue with importlib_metadata describing the motivation for making changes and then propose a change there.

Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/library/importlib.metadata.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/importlib.metadata.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@jaraco jaraco closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco left review comments
@brettcannon brettcannon brettcannon approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jaraco jaraco

Labels

awaiting merge docs Documentation in the Doc dir needs backport to 3.12 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AA-Turner @brettcannon @jaraco @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.