GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105481: opcode.h is no longer generated during the build by iritkatriel · Pull Request #108080 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Aug 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Python's operators don't change very often. This doesn't need to be auto-generated.

  • Issue: Generate opcode metadata from bytecodes.c instead of opcode.py #105481

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-105481: opcode.h is no longer generated during the build
d9373ff
@iritkatriel
iritkatriel requested a review from a team as a code owner August 17, 2023 09:51
@bedevere-bot bedevere-bot added the awaiting core review label Aug 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 17, 2023
Generate opcode metadata from bytecodes.c instead of opcode.py #105481
Closed
@iritkatriel iritkatriel added the skip news label Aug 17, 2023
@iritkatriel
iritkatriel requested a review from gvanrossum August 17, 2023 12:49
iritkatriel
iritkatriel commented Aug 17, 2023
View reviewed changes
Comment thread Makefile.pre.in Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added 2 commits August 17, 2023 13:50
@iritkatriel
typo
f2b445c
@iritkatriel
Merge branch 'main' into _nb_ops
e253a7e
gvanrossum
gvanrossum approved these changes Aug 17, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, though I'm unsure of the benefit here. We now have two places where the list of NB_ constants occurs, once in opcode.h, once in _opcode.c, and they must be kept in sync manually.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/opcode.h
#define NB_INPLACE_TRUE_DIVIDE 24
#define NB_INPLACE_XOR 25

#define NB_OPARG_LAST 25

@gvanrossum gvanrossum Aug 17, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike marking the "last" of anything, you end up doing + 1 in various places. But I realize that it's a convention around opcode definitions and the like.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 17, 2023
@iritkatriel

iritkatriel commented Aug 17, 2023

Copy link
Copy Markdown
Member Author

There are a number of lists/enumerations that need to exist in parallel python and C. I think to avoid the duplication in the code we should design something generic that spawns the #definitions in C and a function that builds the python dict to map the name to the number. Something like argument clinic, but for enumerations. I don't like having a special script for each case.
gvanrossum reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 0b243c2 into python:main Aug 17, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.