GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-101100: Docs: Check Sphinx warnings and fail if improved (GH-106460) by CAM-Gerlach · Pull Request #108116 · python/cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Aug 18, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 806d7c9)

Co-authored-by: Hugo van Kemenade [email protected]

Required to backport #108065


📚 Documentation preview 📚: https://cpython-previews--108116.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk @CAM-Gerlach
pythongh-101100: Docs: Check Sphinx warnings and fail if improved (py…
3bd0fbe
…thon#106460)

(cherry picked from commit 806d7c9)
@CAM-Gerlach CAM-Gerlach added docs Documentation in the Doc dir skip issue skip news labels Aug 18, 2023
@CAM-Gerlach CAM-Gerlach self-assigned this Aug 18, 2023
@CAM-Gerlach
CAM-Gerlach requested review from ezio-melotti and hugovk as code owners August 18, 2023 17:50
@bedevere-bot bedevere-bot mentioned this pull request Aug 18, 2023
gh-101100: Docs: Check Sphinx warnings and fail if improved #106460
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Aug 18, 2023
@CAM-Gerlach @hugovk
[3.12] pythongh-101100: Docs: Check Sphinx warnings and fail if impro…
78dfd24
…ved (pythonGH-106460).

(cherry picked from commit 806d7c9)

Co-authored-by: Hugo van Kemenade <[email protected]>
@CAM-Gerlach
CAM-Gerlach force-pushed the backport-806d7c9-3.12 branch from 6a4df40 to 78dfd24 Compare August 18, 2023 18:09
@CAM-Gerlach

CAM-Gerlach commented Aug 18, 2023

Copy link
Copy Markdown
Member Author

Seems like I guessed wrong on a few of the .nitignore lines when resolving merge conflicts, as I thought I might. Should hopefully be good to go now...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach
CAM-Gerlach requested a review from Yhg1s August 18, 2023 18:15
@CAM-Gerlach CAM-Gerlach assigned Yhg1s and unassigned CAM-Gerlach Aug 18, 2023
@CAM-Gerlach

CAM-Gerlach commented Aug 18, 2023

Copy link
Copy Markdown
Member Author

@Yhg1s Just FYI, this is blocking the highly-requested PR #108065 , so a review and merge would be much appreciated when you get the chance, thanks :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner
AA-Turner approved these changes Aug 18, 2023
View reviewed changes
hugovk
hugovk approved these changes Aug 18, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 18, 2023
@CAM-Gerlach
CAM-Gerlach removed the request for review from ezio-melotti August 18, 2023 20:48
@Yhg1s
Yhg1s merged commit daed54d into python:3.12 Aug 18, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@CAM-Gerlach @hugovk @AA-Turner @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.