GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-101100: Only show GitHub check annotations on changed doc paragraphs (GH-108065) by miss-islington · Pull Request #108127 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 19, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Only show GitHub check annotations on changed doc paragraphs
  • Improve check-warnings script arg parsing following Hugo's suggestions
  • Factor filtering warnings by modified diffs into helper function
  • Build docs on unmerged branch so warning lines match & avoid deep clone

(cherry picked from commit eb953d6)

Co-authored-by: C.A.M. Gerlach [email protected]
Co-authored-by: Hugo van Kemenade [email protected]
Co-authored-by: Adam Turner [email protected]

  • Issue: Fix all Sphinx reference warnings in the documentation #101100

📚 Documentation preview 📚: https://cpython-previews--108127.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CAM-Gerlach @hugovk
@AA-Turner @miss-islington
pythongh-101100: Only show GitHub check annotations on changed doc pa…
4203374 
…ragraphs (pythonGH-108065)

* Only show GitHub check annotations on changed doc paragraphs
* Improve check-warnings script arg parsing following Hugo's suggestions
* Factor filtering warnings by modified diffs into helper function
* Build docs on unmerged branch so warning lines match & avoid deep clone

---------

(cherry picked from commit eb953d6)

Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@miss-islington
miss-islington requested review from ezio-melotti and hugovk as code owners August 19, 2023 00:43
@bedevere-bot bedevere-bot mentioned this pull request Aug 19, 2023
Fix all Sphinx reference warnings in the documentation #101100
Closed
@bedevere-bot bedevere-bot added the skip news label Aug 19, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 19, 2023
gh-101100: Only show GitHub check annotations on changed doc paragraphs #108065
Merged
@bedevere-bot bedevere-bot added the awaiting review label Aug 19, 2023
@CAM-Gerlach
CAM-Gerlach removed the request for review from ezio-melotti August 19, 2023 00:45
CAM-Gerlach
CAM-Gerlach approved these changes Aug 19, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to avoid the warning spam, fix the line numbers and allow them to be checked locally on this branch as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 19, 2023
@CAM-Gerlach
CAM-Gerlach requested a review from Yhg1s August 19, 2023 00:48
@CAM-Gerlach CAM-Gerlach assigned Yhg1s Aug 19, 2023
hugovk
hugovk approved these changes Aug 19, 2023
View reviewed changes
@Yhg1s
Yhg1s merged commit 71e3581 into python:3.12 Aug 19, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 19, 2023
@miss-islington
miss-islington deleted the backport-eb953d6-3.12 branch August 19, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @hugovk @CAM-Gerlach @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.