GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-107801: Improve the accuracy of os.lseek docs (#107935) by erlend-aasland · Pull Request #108136 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 19, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • name the last parameter whence, like it is for seek() methods on
    file objects
  • add param docstrings
  • structure the valid whence params

(cherry picked from commit dd4442c)

Co-authored-by: Adam Turner [email protected]

  • Issue: Docs and docstrings for io.*.seek are inconsistent #107801

📚 Documentation preview 📚: https://cpython-previews--108136.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland @AA-Turner
[3.12] pythongh-107801: Improve the accuracy of os.lseek docs (python…
953b52d
…#107935)

- name the last parameter *whence*, like it is for seek() methods on
  file objects
- add param docstrings
- structure the valid *whence* params

(cherry picked from commit dd4442c)

Co-authored-by: Adam Turner <[email protected]>
This was referenced Aug 19, 2023
Docs and docstrings for io.*.seek are inconsistent #107801
Closed
gh-107801: Improve the accuracy of os.lseek docs #107935
Merged
@bedevere-bot bedevere-bot added skip news awaiting core review labels Aug 19, 2023
@erlend-aasland erlend-aasland assigned Yhg1s Aug 19, 2023
@Yhg1s
Yhg1s merged commit 41634ed into python:3.12 Aug 19, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 19, 2023
@erlend-aasland
erlend-aasland deleted the backport-3.12-lseek branch August 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.