GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108223: Document --disable-gil flag in configure by colesbury · Pull Request #108236 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Aug 21, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds an entry in the configure documentation for the --disable-gil flag.

  • Issue: Add --disable-gil option to configure #108223

📚 Documentation preview 📚: https://cpython-previews--108236.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mara004 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@colesbury
pythongh-108223: Document --disable-gil flag in configure
1c43a5a
@colesbury colesbury added docs Documentation in the Doc dir skip news build The build process and cross-build labels Aug 21, 2023
@colesbury
colesbury requested a review from vstinner August 21, 2023 18:42
@colesbury
colesbury requested review from corona10 and erlend-aasland as code owners August 21, 2023 18:42
@bedevere-bot bedevere-bot mentioned this pull request Aug 21, 2023
Add --disable-gil option to configure #108223
Closed
@bedevere-bot bedevere-bot added the awaiting review label Aug 21, 2023
vstinner
vstinner reviewed Aug 21, 2023
View reviewed changes
Comment thread Doc/using/configure.rst Outdated
.. cmdoption:: --disable-gil

Enables experimental support for running Python without the global
interpreter lock (GIL).

@vstinner vstinner Aug 21, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a reference to the related PEP:

See :pep:`703` "Making the Global Interpreter Lock Optional in CPython".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Doc/using/configure.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
colesbury and others added 2 commits August 21, 2023 14:49
@colesbury @vstinner
Update Doc/using/configure.rst
0a8d23a 
Co-authored-by: Victor Stinner <[email protected]>
@colesbury
Add link to PEP
036157c
vstinner
vstinner approved these changes Aug 21, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the added doc!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 21, 2023
AA-Turner
AA-Turner reviewed Aug 21, 2023
View reviewed changes
Comment thread Doc/using/configure.rst Outdated
Comment on lines +190 to +191
Enables experimental support for running Python without the
:term:`global interpreter lock` (GIL).

@AA-Turner AA-Turner Aug 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a warning admonition emphasising that this is experimental, in development, etc -- mainly to preempt a random twitter recommendation that "No GIL has now been implemented! Rebuild your Python today with --disable-gil..."

Perhaps a fear that won't materialise, though!

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@colesbury colesbury Aug 21, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with adding whatever text you think is helpful. I expect to revisit and update this later in the development cycle based on what's actually integrated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@AA-Turner AA-Turner Aug 21, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam! Victor's simpler change I think is better for now--we don't really advertise building from source to end-users anyway, so I on reflection I think we don't need a high level of warning here.

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner
vstinner reviewed Aug 21, 2023
View reviewed changes
Comment thread Doc/using/configure.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@itamaro

itamaro commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

considering how much "nothing" this flag is currently doing, vs how much hype it could lead to -- perhaps it should be left undocumented for now?

otherwise, i'd add something like "experimental and under active development - does NOT yet provide actual GIL-less capabilities - intended for use only by contributors actively working on implementing PEP-703 and buildbots"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Aug 21, 2023

Copy link
Copy Markdown
Member

considering how much "nothing" this flag is currently doing, vs how much hype it could lead to -- perhaps it should be left undocumented for now?

I disagree. I prefer to provide accurate documentation, because of the hype.
itamaro, Eclips4, and AA-Turner reacted with thumbs up emoji AA-Turner reacted with laugh emoji
All reactions
  • 👍 3 reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Update Doc/using/configure.rst
72b4900
@vstinner
vstinner enabled auto-merge (squash) August 21, 2023 20:26
@vstinner

vstinner commented Aug 21, 2023

Copy link
Copy Markdown
Member

This is always room for enhancement, but IMO that's a good start for the documentation :-) Maybe a reference documentation should be added later for any question related to NOGIL. For now, the doc points to the complete PEP.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 4b32d4f into python:main Aug 21, 2023
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting merge labels Aug 21, 2023
@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

There's a new commit after the PR has been approved.

@vstinner: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from vstinner August 21, 2023 20:37
@colesbury
colesbury deleted the pep703-configure-docs branch September 1, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review build The build process and cross-build docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@colesbury @itamaro @vstinner @bedevere-bot @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.