GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90791: Enable test___all__ on ASAN build by vstinner · Pull Request #108286 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 22, 2023

Copy link
Copy Markdown
Member
  • Only skip modules and tests related to X11 on ASAN builds: run other tests with ASAN.
  • Use print(flush=True) to see output earlier when it's redirected to a pipe.
  • Update issue reference: replace bpo-46633 with AddressSanitizer: Skip tests directly in Python, not with external config #90791.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-90791: Enable test___all__ on ASAN build
6194e97 
* Only skip modules and tests related to X11 on ASAN builds: run
  other tests with ASAN.
* Use print(flush=True) to see output earlier when it's redirected to
  a pipe.
* Update issue reference: replace bpo-46633 with pythongh-90791.
@vstinner vstinner added the skip news label Aug 22, 2023
@vstinner
vstinner requested review from lysnikolaou and pablogsal as code owners August 22, 2023 13:19
@bedevere-bot bedevere-bot mentioned this pull request Aug 22, 2023
AddressSanitizer: Skip tests directly in Python, not with external config #90791
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 22, 2023
@vstinner
vstinner merged commit a541e01 into python:main Aug 22, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 22, 2023
@vstinner
vstinner deleted the asan_test_all branch August 22, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.