GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-108267: Dataclasses docs: Fix object.__setattr__ typo (GH-108355) by miss-islington · Pull Request #108358 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 23, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixed a sentence in dataclasses.rst

Changed "setattr" to "object.setattr" in a section that was specifically supposed to refer to the setattr method of the object class. Also suppressed the link to the data model docs for setattr, since we're talking about a specific setattr implementation, not setattr methods in general.
(cherry picked from commit 79fdacc)

Co-authored-by: FrozenBob [email protected]

  • Issue: Minor mistake in dataclasses documentation update #108267

📚 Documentation preview 📚: https://cpython-previews--108358.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FrozenBob @miss-islington
pythongh-108267: Dataclasses docs: Fix object.__setattr__ typo (pytho…
3276d2b 
…nGH-108355)

Fixed a sentence in dataclasses.rst

Changed "__setattr__" to "object.__setattr__" in a section that was specifically supposed to refer to the __setattr__ method of the object class. Also suppressed the link to the data model docs for __setattr__, since we're talking about a specific __setattr__ implementation, not __setattr__ methods in general.
(cherry picked from commit 79fdacc)

Co-authored-by: FrozenBob <[email protected]>
@miss-islington
miss-islington requested a review from ericvsmith as a code owner August 23, 2023 07:12
This was referenced Aug 23, 2023
Minor mistake in dataclasses documentation update #108267
Closed
gh-108267: Dataclasses docs line should have said "object.__setattr__" instead of just "__setattr__" #108355
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir awaiting review labels Aug 23, 2023
AlexWaygood
AlexWaygood approved these changes Aug 23, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 23, 2023
@AlexWaygood AlexWaygood assigned Yhg1s Aug 23, 2023
@Yhg1s
Yhg1s merged commit 3aa7df6 into python:3.12 Aug 23, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 23, 2023
@miss-islington
miss-islington deleted the backport-79fdacc-3.12 branch August 23, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @AlexWaygood @Yhg1s @bedevere-bot @FrozenBob
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.