GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108308: Use PyDict_GetItemRef() in moduleobject.c by vstinner · Pull Request #108381 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace PyDict_GetItemWithError() with PyDict_GetItemRef() which returns a strong reference.

Cleanup also the function: move variable definition to their first assignation, rename variable names to use name longer than 1 character.

  • Issue: [C API] Use new PyDict_GetItemRef() C API #108308

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-108308: Use PyDict_GetItemRef() in moduleobject.c
c479ee7 
Replace PyDict_GetItemWithError() with PyDict_GetItemRef() which
returns a strong reference.

Cleanup also the function: move variable definition to their first
assignation, rename variable names to use name longer than 1
character.
@vstinner vstinner added the skip news label Aug 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 23, 2023
[C API] Use new PyDict_GetItemRef() C API #108308
Closed
2 tasks done
@bedevere-bot bedevere-bot added the awaiting core review label Aug 23, 2023
@vstinner
vstinner enabled auto-merge (squash) August 23, 2023 21:43
@vstinner
vstinner merged commit 4890f65 into python:main Aug 23, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 23, 2023
@vstinner
vstinner deleted the mod_getitemref branch August 23, 2023 22:46
@vstinner vstinner mentioned this pull request Aug 23, 2023
test_peg_generator and test_freeze require cpu #108386
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.