GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107211: No longer export internal functions (5) by vstinner · Pull Request #108423 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

No longer export these 4 internal C API functions:

  • _PyCompile_AstOptimize()
  • _Py_closerange()
  • _Py_get_osfhandle()
  • _Py_stat()

Change comment style to "// comment" and add comment explaining why other functions have to be exported.

  • Issue: C API: No longer export internal C API functions #107211

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Aug 24, 2023
@vstinner
vstinner requested review from brettcannon, ericsnowcurrently, markshannon, ncoghlan and warsaw as code owners August 24, 2023 14:26
@bedevere-bot bedevere-bot mentioned this pull request Aug 24, 2023
C API: No longer export internal C API functions #107211
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 24, 2023
@vstinner
vstinner force-pushed the dont_export2 branch 2 times, most recently from b835966 to 307c3fe Compare August 24, 2023 15:17
@vstinner
pythongh-107211: No longer export internal functions (5)
1c53af2 
No longer export _PyCompile_AstOptimize() internal C API function.

Change comment style to "// comment" and add comment explaining why
other functions have to be exported.
@vstinner
vstinner force-pushed the dont_export2 branch from 307c3fe to 1c53af2 Compare August 24, 2023 15:30
@vstinner
vstinner enabled auto-merge (squash) August 24, 2023 15:41
@vstinner
vstinner merged commit b780882 into python:main Aug 24, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 24, 2023
@vstinner
vstinner deleted the dont_export2 branch August 24, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.