GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-108388: Convert test_concurrent_futures to package (#108401) by vstinner · Pull Request #108443 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Convert test_concurrent_futures to a package of sub-tests.

(cherry picked from commit aa6f787)

  • Issue: Split long running test suites up into smaller sub suites to reduce our regrtest long tail on multi-core systems. #108388

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-108388: Convert test_concurrent_futures to package (python#1…
d377273 
…08401)

Convert test_concurrent_futures to a package of sub-tests.

(cherry picked from commit aa6f787)
This was referenced Aug 24, 2023
Split long running test suites up into smaller sub suites to reduce our regrtest long tail on multi-core systems. #108388
Closed
gh-108388: Convert test_concurrent_futures to package #108401
Merged
@bedevere-bot bedevere-bot added skip news awaiting core review labels Aug 24, 2023
gpshead
gpshead approved these changes Aug 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 24, 2023
@vstinner

vstinner commented Aug 24, 2023

Copy link
Copy Markdown
Member Author

I backported the change to Python 3.12. There is a minor conflict in libregrtest on:

 SPLITTESTDIRS = {
     "test_asyncio",
+    "test_concurrent_futures",
 }

The backport is in conflict with PR #108401 (split multiprocessing tests) which may be merged first.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead
gpshead requested a review from Yhg1s August 24, 2023 17:43
@gpshead

gpshead commented Aug 24, 2023

Copy link
Copy Markdown
Member

this and the similar PR for test_multiprocessing_* will be a tiny merge conflict in that runtest.py list. easily resolved in one after the other goes in.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Aug 24, 2023
[3.12] gh-108388: Split test_multiprocessing_spawn (GH-108396) #108442
Merged
@Yhg1s
Merge branch '3.12' into test_concurrent_package312
8ad57bd
@Yhg1s
Yhg1s merged commit bba9aa6 into python:3.12 Aug 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 26, 2023
@vstinner
vstinner deleted the test_concurrent_package312 branch August 26, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @gpshead @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.