GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108364: Simplify quoting values and identifiers in sqlite3's iterdump() by felixxm · Pull Request #108472 · python/cpython

Conversation

@felixxm

@felixxm felixxm commented Aug 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Cleanup for #108340.

  • Issue: Align sqlite3.Connection.iterdump with the .dump() command of the SQLite shell #108364

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@felixxm
felixxm requested review from berkerpeksag and erlend-aasland as code owners August 25, 2023 09:19
@bedevere-bot bedevere-bot added the awaiting review label Aug 25, 2023
@felixxm felixxm mentioned this pull request Aug 25, 2023
gh-64662: Add virtual table support to sqlite3.Connection.iterdump #108340
Merged
felixxm
felixxm commented Aug 25, 2023
View reviewed changes
Comment thread Lib/sqlite3/dump.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

This is a nice cleanup. I think we should add this as a separate PR, instead of as a part of #108340.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title Simplify quoting values/identifiers in sqlite3.dump._iter dump(). gh-108364: Simplify quoting values and identifiers in sqlite3's iterdump() Aug 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 25, 2023
Align sqlite3.Connection.iterdump with the .dump() command of the SQLite shell #108364
Closed
@erlend-aasland erlend-aasland added the skip news label Aug 25, 2023
@felixxm
pythongh-108364: Simplify quoting values/identifiers in sqlite3.dump.…
2423154 
…_iter dump().
@felixxm
felixxm force-pushed the sqlite-dump-readable branch from 333c0f5 to 2423154 Compare August 25, 2023 09:42
@felixxm

felixxm commented Aug 25, 2023

Copy link
Copy Markdown
Contributor Author

This is a nice cleanup. I think we should add this as a separate PR, instead of as a part of #108340.

Agreed. #108340 could use new hooks so I would merge this PR first.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Agreed. #108340 could use new hooks so I would merge this PR first.

Sounds good to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Merge branch 'main' into sqlite-dump-readable
cb1316a
@erlend-aasland

erlend-aasland commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Seems main was recently broken by #107988; we'll have to wait for that issue to be resolved before landing.
felixxm reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Merge branch 'main' into sqlite-dump-readable
44ad918
erlend-aasland
erlend-aasland approved these changes Aug 25, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 25, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 25, 2023 12:05
@erlend-aasland
erlend-aasland merged commit 75903f2 into python:main Aug 25, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 25, 2023
@felixxm
felixxm deleted the sqlite-dump-readable branch August 25, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@felixxm @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.