GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-108494: Fix AC limited C API for kwargs by vstinner · Pull Request #108516 · python/cpython

Conversation

vstinner commented Aug 26, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Fix the limited C API code path in Argument Clinic to parse "positional or keywords" arguments.

Add an unit test in _testclinic_limited.

Issue: Add support for the limited C API to Argument Clinic #108494

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-108494: Fix AC limited C API for kwargs

21ad1fc

Fix the limited C API code path in Argument Clinic to parse
"positional or keywords" arguments.

Add an unit test in _testclinic_limited.

vstinner added the skip news label

Aug 26, 2023

vstinner requested review from AlexWaygood and erlend-aasland as code owners

August 26, 2023 15:13

bedevere-bot mentioned this pull request

Aug 26, 2023

Add support for the limited C API to Argument Clinic #108494

Closed

bedevere-bot added the awaiting core review label

Aug 26, 2023

vstinner commented Aug 26, 2023

Copy link

Copy Markdown

Member Author

@erlend-aasland @AlexWaygood @serhiy-storchaka: Here is a fix for PyArg_ParseTupleAndKeywords(). It removes the unused argname_fmt in the PyArg_ParseTuple() code path.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka reviewed

Aug 26, 2023

View reviewed changes

Comment thread

Tools/clinic/clinic.py

		""", indent=4)]
		declarations = ""

		else:

serhiy-storchaka Aug 26, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work if requires_defining_class is true?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Aug 26, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't. This change is incomplete, it can be completed later. Or do you mean that an exception should be raised instead of an compilation error?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka Aug 27, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it can produce invalid code which is compiled. There are two opposite approaches:

Raise an exception or ensure that the compiling the generated code will get a compilation error.
Try to use the limited API if possible, but fallback to private API otherwise.

I am currently trying the second approach. It allows to re-generate all clinic code using the limited API and test that at least it works (I found many cases in which the current code does not generate working code). Please hold this PR, the current code is more suitable for this experiment. After testing it will be easy to switch to the first approach.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Aug 27, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A module targeting the limited C API cannot use the private API. It fails at build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Tools/clinic/clinic.py

		# positional-only for the limited C API
		flags = "METH_VARARGS"
		elif clinic.limited_capi:
		if not requires_defining_class and pos_only == len(parameters) - pseudo_args:

serhiy-storchaka Aug 26, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work if pseudo_args is not zero?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Aug 26, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. I don't know what are pseudo args.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Tools/clinic/clinic.py

		{parse_arguments}))
		goto exit;
		""", indent=4)]
		declarations = "char* _keywords[] = {{{keywords_c} NULL}};"

serhiy-storchaka Aug 26, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	declarations = "char* _keywords[] = {{{keywords_c} NULL}};"
	declarations = "static char *_keywords[] = {{{keywords_c} NULL}};"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Aug 26, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't reallly understand the difference between the two. The value is constant so the variable should not really exist on the stack, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka Aug 27, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a difference. It is an array of pointers. If it is a local variable, it should fill with initial values every time the function is called. If it is a static variable, it is only filled with initial values at the program's start (or when the function is called first time).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

serhiy-storchaka commented Aug 27, 2023

Copy link

Copy Markdown

Member

See #108536.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner commented Aug 27, 2023

Copy link

Copy Markdown

Member Author

Does your PR make this one useless, or should it be merged first?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka commented Aug 27, 2023

Copy link

Copy Markdown

Member

I think that it makes it useless, maybe except the test. But for testing I want to reuse existing tests, so the current Modules/_testclinic_limited.c will become obsolete too.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner commented Aug 28, 2023

Copy link

Copy Markdown

Member Author

Serhiy's PR got merged and it's way more complete, I close this PR: #108536

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner closed this

Aug 28, 2023

vstinner deleted the clinic_limited_kwds branch

August 28, 2023 14:23

Reviewers

serhiy-storchaka

serhiy-storchaka left review comments

erlend-aasland

Awaiting requested review from erlend-aasland

erlend-aasland is a code owner

AlexWaygood

Awaiting requested review from AlexWaygood

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

vstinner commented Aug 26, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Aug 26, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Aug 27, 2023

Uh oh!

vstinner commented Aug 27, 2023

Uh oh!

serhiy-storchaka commented Aug 27, 2023

Uh oh!

vstinner commented Aug 28, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vstinner commented Aug 26, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.