GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-64662: Fix virtual table support in sqlite3.Connection.iterdump (#108340) by erlend-aasland · Pull Request #108564 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit d0160c7)

Co-authored-by: Aviv Palivoda [email protected]

  • Issue: sqlite dumpiter dumps invalid script when virtual tables are used #64662

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @palaviv
[3.11] pythongh-64662: Add virtual table support to sqlite3.Connectio…
cd0cd13 
…n.iterdump (python#108340)

(cherry picked from commit d0160c7)

Co-authored-by: Aviv Palivoda <[email protected]>
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner August 28, 2023 11:46
This was referenced Aug 28, 2023
sqlite dumpiter dumps invalid script when virtual tables are used #64662
Closed
gh-64662: Add virtual table support to sqlite3.Connection.iterdump #108340
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Aug 28, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 28, 2023 11:48
@erlend-aasland erlend-aasland changed the title [3.11] gh-64662: Add virtual table support to sqlite3.Connection.iterdump (#108340) [3.11] gh-64662: Fix virtual table support in sqlite3.Connection.iterdump (#108340) Aug 28, 2023
@erlend-aasland
erlend-aasland disabled auto-merge August 28, 2023 11:48
@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 28, 2023 11:48
erlend-aasland added 3 commits August 28, 2023 14:03
@erlend-aasland
The _quote_value helper is not part of 3.11; spell out the replacement
c912460
@erlend-aasland
With quotes
e09ee53
@erlend-aasland
Ok, let's use explicit quoting
6fa7faa
@erlend-aasland
erlend-aasland merged commit 33eee43 into python:3.11 Aug 28, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 28, 2023
@erlend-aasland
erlend-aasland deleted the backport-3.11-sqlite-virtual-tables branch August 31, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.