GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-85283: _scproxy uses the limited C API by vstinner · Pull Request #108572 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The _scproxy (macOS) C extension is now built with the limited C API.

  • Issue: [C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot mentioned this pull request Aug 28, 2023
[C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 28, 2023
@vstinner
vstinner force-pushed the limited_scproxy branch from 6bbead6 to f31fe9c Compare August 28, 2023 16:00
@vstinner
pythongh-85283: _scproxy uses the limited C API
d2d784b 
The _scproxy (macOS) C extension is now built with the limited C API.
@vstinner
vstinner force-pushed the limited_scproxy branch from f31fe9c to d2d784b Compare August 28, 2023 16:02
@vstinner
Replace Py_SETREF(v, NULL) with Py_CLEAR(v)
dbc373a 
Py_SETREF() is not part of the limited C API
@vstinner
vstinner marked this pull request as draft August 31, 2023 16:54
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 31, 2023
@vstinner

vstinner commented Aug 31, 2023

Copy link
Copy Markdown
Member Author

I prefer to hold this PR (mark it as a draft) until the first extension is converted to the limited C API: PR #108573.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 1, 2023

Copy link
Copy Markdown
Member Author

I close the PR for now, it's trivial to rewrite. I will reopen it once a consensus is found on issue #85283.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Sep 1, 2023
@vstinner
vstinner deleted the limited_scproxy branch September 1, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.