GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-107603: Clinic: Pass specific attributes to ``print_block()`` by AA-Turner · Pull Request #108581 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

xref #108486 (comment), opened for discussion.

A

  • Issue: Argument Clinic includes internal headers in generated output unconditionally #107603

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Clinic: Only pass includes to print_block()
ef8011e
@AA-Turner AA-Turner added skip news topic-argument-clinic labels Aug 28, 2023
@AA-Turner
AA-Turner requested review from AlexWaygood and erlend-aasland as code owners August 28, 2023 19:59
@bedevere-bot bedevere-bot mentioned this pull request Aug 28, 2023
Argument Clinic includes internal headers in generated output unconditionally #107603
Closed
@bedevere-bot bedevere-bot added the awaiting review label Aug 28, 2023
@AA-Turner AA-Turner mentioned this pull request Aug 28, 2023
gh-107603: Argument Clinic can emit includes #108486
Merged
@AA-Turner

AA-Turner commented Aug 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

mypy failure seems unrelated: (Edit: very related!)
AlexWaygood reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Aug 28, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
limited_capi, too
373f13e
@AA-Turner AA-Turner changed the title GH-107603: Clinic: Only pass includes to print_block() GH-107603: Clinic: Pass specific attributes to print_block() Aug 28, 2023
AlexWaygood
AlexWaygood reviewed Aug 28, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added 2 commits August 28, 2023 21:19
@AA-Turner
tighten header_includes
91456c7
@AA-Turner
tighten limited_capi
72b4999
vstinner
vstinner approved these changes Aug 28, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 28, 2023
AlexWaygood
AlexWaygood approved these changes Aug 28, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@AA-Turner

AA-Turner commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

Thanks all for the (incredibly fast) reviews!

A
AlexWaygood and erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Aug 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Oh, looks like you'll need to slightly rework two unit tests in test_clinic.py to get CI passing
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
tests
1512b9d
@AlexWaygood
AlexWaygood enabled auto-merge (squash) August 28, 2023 20:39
@AlexWaygood
AlexWaygood merged commit 0bd2ba5 into python:main Aug 28, 2023
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting merge labels Aug 28, 2023
@bedevere-bot

This comment was marked as abuse.

Sign in to view
@bedevere-bot
bedevere-bot requested review from AlexWaygood and vstinner August 28, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news topic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AA-Turner @AlexWaygood @bedevere-bot @vstinner @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.