GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108494: Build _testclinic_limited on Windows by vstinner · Pull Request #108589 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add _testclinic_limited project to the Visual Studio solution:

  • In PCbuild/, copy _asyncio.vcxproj to _testclinic_limited.vcxproj,
    replace RootNamespace with "_testclinic_limited".
  • In Visual Stuido, open PCbuild\pcbuild.sln, add the existing
    "_testclinic_limited" project to the solution.
  • Add a dependency from "python" project to "_testclinic_limited"
    project.
  • Save and exit VS.
  • Add "_testclinic_limited" to
    in PCbuild\pcbuild.proj.
  • Issue: Add support for the limited C API to Argument Clinic #108494

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood and erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@bedevere-bot bedevere-bot mentioned this pull request Aug 28, 2023
Add support for the limited C API to Argument Clinic #108494
Closed
@vstinner vstinner added the skip news label Aug 28, 2023
@vstinner
vstinner force-pushed the ac_build_test_limited_win branch from 46c8d54 to 4c79ccb Compare August 28, 2023 23:20
@vstinner vstinner changed the title gh-108494: AC: Build _testclinic_limited on Windows gh-108494: Build _testclinic_limited on Windows Aug 28, 2023
@vstinner
vstinner marked this pull request as ready for review August 28, 2023 23:21
@vstinner
vstinner requested a review from a team as a code owner August 28, 2023 23:21
@bedevere-bot bedevere-bot added the awaiting core review label Aug 28, 2023
@vstinner
pythongh-108494: Build _testclinic_limited on Windows
07d21ec 
Add _testclinic_limited project to the Visual Studio solution:

* In PCbuild/, copy _asyncio.vcxproj to _testclinic_limited.vcxproj,
  replace RootNamespace with "_testclinic_limited".
* In Visual Stuido, open PCbuild\pcbuild.sln, add the existing
  "_testclinic_limited" project to the solution.
* Add a dependency from "python" project to "_testclinic_limited"
  project.
* Save and exit VS.
* Add "_testclinic_limited" to <TestModules Include="...">
  in PCbuild\pcbuild.proj.
@vstinner
vstinner force-pushed the ac_build_test_limited_win branch from 4c79ccb to 07d21ec Compare August 28, 2023 23:26
@vstinner

vstinner commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

The _testclinic_limited is now build as expected on Windows. Logs of the Windows x64 GHA CI:

  _testclinic_limited.c
     Creating library D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.lib and object D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.exp
  _testclinic_limited.vcxproj -> D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.pyd
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) August 28, 2023 23:33
@vstinner
vstinner merged commit 5c68cba into python:main Aug 28, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 28, 2023
@vstinner vstinner mentioned this pull request Aug 28, 2023
gh-108494: Argument Clinic partial supports of Limited C API #108495
Merged
@vstinner
vstinner deleted the ac_build_test_limited_win branch August 28, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.