GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106320: Remove private _Py_Identifier API by vstinner · Pull Request #108593 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove the private _Py_Identifier type and related private functions from the public C API:

  • _PyObject_GetAttrId()
  • _PyObject_LookupSpecialId()
  • _PyObject_SetAttrId()
  • _PyType_LookupId()
  • _Py_IDENTIFIER()
  • _Py_static_string()
  • _Py_static_string_init()

Move them to the internal C API: add a new pycore_identifier.h header file. No longer export these functions.

  • Issue: C API: Remove private C API functions (move them to the internal C API) #106320

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Aug 28, 2023
@vstinner
vstinner requested a review from a team as a code owner August 28, 2023 23:59
@bedevere-bot bedevere-bot mentioned this pull request Aug 28, 2023
C API: Remove private C API functions (move them to the internal C API) #106320
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 28, 2023
@vstinner

vstinner commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

Related discussion: https://discuss.python.org/t/c-api-how-much-private-is-the-private-py-identifier-api/29190
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-106320: Remove private _Py_Identifier API
7ccbf0b 
Remove the private _Py_Identifier type and related private functions
from the public C API:

* _PyObject_GetAttrId()
* _PyObject_LookupSpecialId()
* _PyObject_SetAttrId()
* _PyType_LookupId()
* _Py_IDENTIFIER()
* _Py_static_string()
* _Py_static_string_init()

Move them to the internal C API: add a new pycore_identifier.h header
file. No longer export these functions.
@vstinner
vstinner force-pushed the pycore_identifier branch from d593732 to 7ccbf0b Compare August 29, 2023 00:00
@vstinner
vstinner merged commit 4fb96a1 into python:main Aug 29, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 29, 2023
@vstinner
vstinner deleted the pycore_identifier branch August 29, 2023 00:29
@osandov osandov mentioned this pull request Oct 23, 2023
Handle private APIs removed in Python 3.13 osandov/drgn#361
Closed
@osandov

osandov commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Is there a recommendation for what to use instead? I read the discussion linked, but it didn't seem like there was a conclusion on the replacement.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 27, 2023

Copy link
Copy Markdown
Member Author

Is there a recommendation for what to use instead? I read the discussion linked, but it didn't seem like there was a conclusion on the replacement.

I'm worried about these APIs :-( No consensus was found on a migration plan to move away from this private API. Maybe we should consider adding back the private API for now until a clear consensus is found.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 30, 2023
[C API] Meta issue: add new public functions with doc+tests to replace removed private functions #111481
Closed
[C API] Provide a replacement for removed private _Py_Identifier API, or consider reverting the removal #111484
Closed
@vstinner

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

@osandov:

Is there a recommendation for what to use instead? I read the discussion linked, but it didn't seem like there was a conclusion on the replacement.

I created #111484
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JukkaL JukkaL mentioned this pull request Oct 14, 2025
[mypyc] feat: cache ids for fallback pythonic method lookups [1/1] python/mypy#19870
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @osandov @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.