GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106320: Remove private _PyOS_IsMainThread() function by vstinner · Pull Request #108605 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move the following private API to the internal C API (pycore_signal.h):

  • _PyOS_IsMainThread()
  • _PyOS_SigintEvent()

No longer export these functions.

  • Issue: C API: Remove private C API functions (move them to the internal C API) #106320

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Aug 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 29, 2023
C API: Remove private C API functions (move them to the internal C API) #106320
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 29, 2023
@vstinner
pythongh-106320: Remove private _PyOS_IsMainThread() function
f3eaba7 
Move the following private API to the internal C API
(pycore_signal.h): _PyOS_IsMainThread() and _PyOS_SigintEvent().
@vstinner
vstinner force-pushed the pycore_signal branch from 063392b to f3eaba7 Compare August 29, 2023 02:38
@vstinner
vstinner enabled auto-merge (squash) August 29, 2023 03:02
@vstinner
vstinner merged commit fadc2dc into python:main Aug 29, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 29, 2023
@vstinner
vstinner deleted the pycore_signal branch August 29, 2023 03:40
@jbms

jbms commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

This breaks tensorstore, specifically due to the usage of _PyOS_SigintEvent here: https://github.com/google/tensorstore/blob/798025f874c7579b2eb900932bf7c56d4f8ebd62/python/tensorstore/future.cc#L75

It is used in order to make a blocking wait within the main thread interruptible via Control+C on Windows. I don't know of any easy alternative. For now I will be using the workaround of copying the declaration to my own source file, but if the function is eventually removed entirely that won't work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 11, 2024

Copy link
Copy Markdown
Member Author

Would you mind to open a new issue since this one is closed? Please explain your use case and why you need this function to be exposed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jan 9, 2025

Copy link
Copy Markdown
Member Author

Ping @jbms.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jbms jbms mentioned this pull request Jan 9, 2025
_PyOS_SigintEvent() is needed for interruptible waiting on main thread #128684
Open
@jbms

jbms commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Ping @jbms.

Created #128684
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @jbms @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.