GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108494: Don't build _testclinic_limited with TraceRefs by vstinner · Pull Request #108608 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

If Python is built with ./configure --with-trace-refs, don't build the _testclinic_limited extension. The limited C API (Py_LIMITED_API) is not compatible with Py_TRACE_REFS.

  • Issue: Add support for the limited C API to Argument Clinic #108494

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-108494: Don't build _testclinic_limited with TraceRefs
ca64489 
If Python is built with ./configure --with-trace-refs, don't build
the _testclinic_limited extension. The limited C API (Py_LIMITED_API)
is not compatible with Py_TRACE_REFS.
@vstinner
vstinner requested review from corona10 and erlend-aasland as code owners August 29, 2023 02:48
@bedevere-bot bedevere-bot mentioned this pull request Aug 28, 2023
Add support for the limited C API to Argument Clinic #108494
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 29, 2023
@vstinner vstinner added skip news and removed awaiting core review labels Aug 29, 2023
@vstinner

vstinner commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

Currently, building Python on the TraceRefs buildbot fails with:

gcc  -fno-strict-overflow -Wsign-compare -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -Og -Wall    -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden  -I./Include/internal  -I. -I./Include    -fPIC -c ./Modules/_testclinic_limited.c -o Modules/_testclinic_limited.o
In file included from ./Include/Python.h:44,
                 from ./Modules/_testclinic_limited.c:7:
./Include/object.h:62:4: error: #error Py_LIMITED_API is incompatible with Py_TRACE_REFS
   62 | #  error Py_LIMITED_API is incompatible with Py_TRACE_REFS
      |    ^~~~~
make: *** [Makefile:3139: Modules/_testclinic_limited.o] Error 1

link: https://buildbot.python.org/all/#/builders/484/builds/3914

You can reproduce with:

make distclean
./configure --with-pydebug --with-trace-refs && make

With this change, the build completes as expected and test_clinic pass:

$ make && ./python -m test -v test_clinic 

The following modules are *disabled* in configure script:
_testclinic_limited   xxlimited             xxlimited_35       

(...)
test_my_int_func (test.test_clinic.LimitedCAPIFunctionalTest.test_my_int_func) ... skipped '_testclinic_limited is missing'
test_my_int_sum (test.test_clinic.LimitedCAPIFunctionalTest.test_my_int_sum) ... skipped '_testclinic_limited is missing'
(...)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

cc @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Aug 29, 2023
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Aug 29, 2023
@vstinner
vstinner merged commit bf08131 into python:main Aug 29, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 29, 2023
@vstinner
vstinner deleted the testclinic_limited_tracerefs branch August 29, 2023 11:39
@vstinner

vstinner commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

Merged, thanks for the review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.