GeezerVison is showing github.com — [3.10] Fix `inspect.signature` call on mocks (#96335) (gh-96127) by thechrisu · Pull Request #108652 · python/cpython
Conversation
thechrisu
commented
Aug 29, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Backporting this fix to make inspect.signature() work with AsyncMock().
This was previously considered in #101647, but that required more rework. The change looked pretty straightforward, and tests passed locally, so putting this up.
Followed process at https://devguide.python.org/#quick-reference to create PR
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hi, thanks for the PR! Unfortunately, Python 3.10 is now quite an old version of Python, that's only accepting security fixes. This isn't a security fix, as far as I can tell. I'm therefore closing this, but thanks again for the contribution :)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
cjw296
Awaiting requested review from cjw296
cjw296 is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
