GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108297: Remove test_crashers by vstinner · Pull Request #108690 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The test was skipped in 2011 by
commit 89ba56d.

Scripts in Lib/test/crashers/ do not crash on a reliable way. They rely on undefined behaviors, like state of the stack memory, and so may or may not crash. It is not worth it to make sure that they crash in a continious integration, they should be run manually time to time instead.

  • Issue: Update test_crashers #108297

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-108297: Remove test_crashers
f6a5c91 
The test was skipped in 2011 by
commit 89ba56d.

Scripts in Lib/test/crashers/ do not crash on a reliable way. They
rely on undefined behaviors, like state of the stack memory, and so
may or may not crash. It is not worth it to make sure that they crash
in a continious integration, they should be run manually time to time
instead.
@vstinner

vstinner commented Aug 30, 2023

Copy link
Copy Markdown
Member Author

I do not want to backport the change to stable branches, it's fine to keep test_crashers.py there, it is skipped since 2011 anyway.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Aug 30, 2023

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Aug 30, 2023
Update test_crashers #108297
Closed
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 30, 2023
@vstinner vstinner added the skip news label Aug 30, 2023
sobolevn
sobolevn reviewed Aug 30, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about crashes/ dir?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented Aug 30, 2023

Copy link
Copy Markdown
Member Author

Lib/test/crashes/ should stay.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka requested a review from ncoghlan August 30, 2023 17:42
@serhiy-storchaka

serhiy-storchaka commented Aug 30, 2023

Copy link
Copy Markdown
Member

test_crashers was added in 2011 and disabled 3 days and 2 minutes later. It was not used since.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Aug 30, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 30, 2023
@vstinner

vstinner commented Aug 30, 2023

Copy link
Copy Markdown
Member Author

test_crashers was added in 2011 and disabled 3 days and 2 minutes later. It was not used since.

LOL. Really? Oh wow... that's the shortest test lifetime in the Python test suite :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit f59c66e into python:main Aug 30, 2023
@vstinner
vstinner deleted the remove_test_crashers branch August 30, 2023 19:33
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting merge labels Aug 30, 2023
@bedevere-bot

This comment was marked as abuse.

Sign in to view
@bedevere-bot
bedevere-bot requested a review from serhiy-storchaka August 30, 2023 19:33
@ncoghlan ncoghlan mentioned this pull request Jul 8, 2024
gh-108297: Update crashers README for test_crashers removal #121475
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @serhiy-storchaka @bedevere-bot @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.