GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-108520: Fix bad fork detection in nested multiprocessing use case (GH-108568) by miss-islington · Pull Request #108691 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

gh-107275 introduced a regression where a SemLock would fail being passed along nested child processes, as the is_fork_ctx attribute would be left missing after the first deserialization.


(cherry picked from commit add8d45)

Co-authored-by: albanD [email protected]
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Antoine Pitrou [email protected]

  • Issue: Nested multiprocessing leads to AttributeError: is_fork_ctx with forkserver or spawn methods #108520

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@albanD @blurb-it
@pitrou @miss-islington
pythongh-108520: Fix bad fork detection in nested multiprocessing use…
4b19d41
… case (pythonGH-108568)

pythongh-107275 introduced a regression where a SemLock would fail being passed along nested child processes, as the `is_fork_ctx` attribute would be left missing after the first deserialization.

---------

(cherry picked from commit add8d45)

Co-authored-by: albanD <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Antoine Pitrou <[email protected]>
This was referenced Aug 30, 2023
Nested multiprocessing leads to AttributeError: is_fork_ctx with forkserver or spawn methods #108520
Closed
gh-108520: Fix bad fork detection in nested multiprocessing use case #108568
Merged
@bedevere-bot bedevere-bot added the awaiting review label Aug 30, 2023
pitrou
pitrou approved these changes Aug 30, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 30, 2023
@Yhg1s
Yhg1s merged commit 320d398 into python:3.12 Aug 30, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 30, 2023
@miss-islington
miss-islington deleted the backport-add8d45-3.12 branch August 30, 2023 21:18
@pitrou

pitrou commented Aug 30, 2023

Copy link
Copy Markdown
Member

Thanks @Yhg1s . I'm sorry for the original regression.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @pitrou @Yhg1s @bedevere-bot @albanD
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.