GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-9004: Recommend against using utctimetuple in the docs. by abalkin · Pull Request #10870 · python/cpython

Conversation

@abalkin

@abalkin abalkin commented Dec 3, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes bpo-9004.

Original patch by Gaurav Tatke.

https://bugs.python.org/issue9004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@abalkin
Recommend against using utctimetuple in the docs.
270f17b 
Closes issue 9004.

Original patch by Gaurav Tatke.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 3, 2018
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Dec 3, 2018
@nanjekyejoannah

nanjekyejoannah commented Mar 11, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@abalkin please add a news entry.

You can use https://blurb-it.herokuapp.com/ to do this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nanjekyejoannah
nanjekyejoannah reviewed Mar 11, 2019
View reviewed changes
Comment thread Doc/library/datetime.rst
If *tz* is not ``None``, it must be an instance of a :class:`tzinfo` subclass, and the
current date and time are converted to *tz*’s time zone. In this case the
result is equivalent to ``tz.fromutc(datetime.utcnow().replace(tzinfo=tz))``.
It is recommended to create aware datetime object for current UTC time by

@nanjekyejoannah nanjekyejoannah Mar 11, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am not a native english speaker but shouldn't this "It is recommended to create aware datetime object " be "It is recommended to create an aware datetime object for current" or "be "It is recommended to create aware datetime objects for current"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JulienPalard JulienPalard Sep 11, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am not a native english speaker neither but I'd propose:

The recommended way to create aware datetime object for the current time in UTC is ...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@csabella

csabella commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

cc @pganssle
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pganssle
pganssle self-requested a review June 16, 2019 14:37
@JulienPalard JulienPalard added the skip news label Sep 11, 2019
@JulienPalard

JulienPalard commented Sep 11, 2019

Copy link
Copy Markdown
Member

@abalkin there's now a conflict on your PR, would you please rebase it on top of master?

@pganssle does this looks good to you? Have you a preferred wording?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pganssle

pganssle commented Sep 11, 2019

Copy link
Copy Markdown
Member

I think maybe we should consolidate this into #15773.

@nanjekyejoannah Do you mind adding a similar warning box to .utctimetuple()? I don't think I even realized that this function exists 😞
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pganssle pganssle mentioned this pull request Sep 11, 2019
bpo-37488 : Document a warning for datetime.utcnow() and utcfromtimestamp() #15773
Merged
@pganssle

pganssle commented Sep 11, 2019

Copy link
Copy Markdown
Member

Closed in favor of #15773
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pganssle pganssle closed this Sep 11, 2019
@abalkin abalkin mentioned this pull request Apr 10, 2022
datetime.utctimetuple() should not set tm_isdst flag to 0 #53250
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard left review comments
@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments
@pganssle pganssle Awaiting requested review from pganssle

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@abalkin @nanjekyejoannah @csabella @JulienPalard @pganssle @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.