GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108765: Python.h no longer includes <sys/time.h> by vstinner · Pull Request #108775 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 1, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Python.h no longer includes these standard header files: <time.h>, <sys/select.h> and <sys/time.h>. They should now be included explicitly if needed.

  • Issue: C API: Cleanup header files #108765

📚 Documentation preview 📚: https://cpython-previews--108775.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
FirePowi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot mentioned this pull request Sep 1, 2023
C API: Cleanup header files #108765
Closed
@vstinner vstinner mentioned this pull request Sep 1, 2023
gh-108765: [TEST] Test combined Python.h changes #108784
Closed
@vstinner
vstinner force-pushed the include_time branch from 09176ab to ccab234 Compare September 2, 2023 14:39
@vstinner
pythongh-108765: Python.h no longer includes <sys/time.h>
e222234 
Python.h no longer includes <time.h>, <sys/select.h> and <sys/time.h>
standard header files.

* Add <time.h> include to xxsubtype.c.
* Add <sys/time.h> include to posixmodule.c and semaphore.c.
* readline.c includes <sys/select.h> instead of <sys/time.h>.
* resource.c no longer includes <time.h> and <sys/time.h>.
@vstinner
vstinner force-pushed the include_time branch from ccab234 to e222234 Compare September 2, 2023 14:54
@vstinner
vstinner marked this pull request as ready for review September 2, 2023 15:07
@vstinner
vstinner requested review from abalkin and pganssle as code owners September 2, 2023 15:07
@bedevere-bot bedevere-bot added the awaiting core review label Sep 2, 2023
@vstinner

vstinner commented Sep 2, 2023

Copy link
Copy Markdown
Member Author

I merged my PR.

If it causes too many trouble in 3rd party C extensions (require to update too many C extensions before Python 3.13 beta1), I can make this change conditional only in the limited C API version 3.13.

See also my PR removing <unistd.h>: PR #108783.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit e7de0c5 into python:main Sep 2, 2023
@vstinner
vstinner deleted the include_time branch September 2, 2023 15:51
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.