GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-108822: regrtest computes statistics (#108793) by vstinner · Pull Request #108833 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 2, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

test_netrc, test_pep646_syntax and test_xml_etree now return results in the test_main() function.

Changes:

  • Rewrite TestResult as a dataclass with a new State class.
  • Add test.support.TestStats class and Regrtest.stats_dict attribute.
  • libregrtest.runtest functions now modify a TestResult instance in-place.
  • libregrtest summary lists the number of run tests and skipped tests, and denied resources.
  • Add TestResult.has_meaningful_duration() method.
  • Compute TestResult duration in the upper function.
  • Use time.perf_counter() instead of time.monotonic().
  • Regrtest: rename 'resource_denieds' attribute to 'resource_denied'.
  • Rename CHILD_ERROR to MULTIPROCESSING_ERROR.
  • Use match/case syntadx to have different code depending on the test state.

Notes on the backport: doctest.TestResults.skipped is a new feature in Python 3.13, so don't use it in the backport.

Co-authored-by: Alex Waygood [email protected]
(cherry picked from commit d4e534c)

  • Issue: regrtest: compute statistics on executed tests #108822

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @AlexWaygood
pythongh-108822: regrtest computes statistics (python#108793)
2271eb1 
test_netrc, test_pep646_syntax and test_xml_etree now return results
in the test_main() function.

Changes:

* Rewrite TestResult as a dataclass with a new State class.
* Add test.support.TestStats class and Regrtest.stats_dict attribute.
* libregrtest.runtest functions now modify a TestResult instance
  in-place.
* libregrtest summary lists the number of run tests and skipped
  tests, and denied resources.
* Add TestResult.has_meaningful_duration() method.
* Compute TestResult duration in the upper function.
* Use time.perf_counter() instead of time.monotonic().
* Regrtest: rename 'resource_denieds' attribute to 'resource_denied'.
* Rename CHILD_ERROR to MULTIPROCESSING_ERROR.
* Use match/case syntadx to have different code depending on the
  test state.

Notes on the backport: doctest.TestResults.skipped is a new feature
in Python 3.13, so don't use it in the backport.

Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit d4e534c)
@bedevere-bot bedevere-bot mentioned this pull request Sep 2, 2023
regrtest: compute statistics on executed tests #108822
Closed
@bedevere-bot bedevere-bot added skip issue skip news labels Sep 2, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 2, 2023
regrtest computes statistics #108793
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Sep 2, 2023
@vstinner vstinner mentioned this pull request Sep 2, 2023
[3.12] regrtest computes statistics (GH-108793) #108818
Closed
@vstinner

vstinner commented Sep 3, 2023

Copy link
Copy Markdown
Member Author

Notes on the backport: doctest.TestResults.skipped is a new feature in Python 3.13, so don't use it in the backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 3, 2023

Copy link
Copy Markdown
Member Author

In general, I'm trying to keep libregrtest the same in all stable branches.

Python 3.11 has an outdated libregrtest. I wrote to backport regrtest changes of last months to Python 3.11: #108820 I just merged my PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s
Yhg1s merged commit c8cf6be into python:3.12 Sep 4, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 4, 2023
@vstinner
vstinner deleted the regrtest312 branch September 4, 2023 19:42
@vstinner

vstinner commented Sep 4, 2023

Copy link
Copy Markdown
Member Author

@Yhg1s Yhg1s merged commit c8cf6be into python:3.12 Sep 4, 2023

Thanks. IMO it's good to have it! If there is any regression, well, it will be fixed as usual :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.