GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — bpo-35398: Improve DDL statement detection for SQLite by montanalow · Pull Request #10913 · python/cpython Conversation
|
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I've signed the CLA with both my github name and BPO name. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the PR. This would require signing a CLA as indicated. Travis fails due to indentation in your code. Please run |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You can use |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Using You also need add test-cases, I guess you can modify existing test-case with some comments. And a "News Entry", using |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
To be honest, I'm not very skilled too. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
From my reading of |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@montanalow you have signed the CLA but your github is not associated to your BPO account. Could you update it because without that we can not review your code. Thank you |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the PR, but closing as the CLA has not been signed within the last month. If you do decide to sign the CLA we can re-open this PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See also #13216 which solves this much more reliably. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.