GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109162: Regrtest copies 'ns' attributes by vstinner · Pull Request #109168 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Regrtest.init() now copies 'ns' namespace attributes to Regrtest attributes. Regrtest match_tests and ignore_tests attributes have type FilterTuple (tuple), instead of a list.
  • Add RunTests.copy(). Regrtest._rerun_failed_tests() now uses RunTests.copy().
  • Replace Regrtest.all_tests (list) with Regrtest.first_runtests (RunTests).
  • Make random_seed maximum 10x larger (9 digits, instead of 8).
  • Issue: Refactor test.libregrtest #109162

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-109162: Regrtest copies 'ns' attributes
8639d99
* Regrtest.__init__() now copies 'ns' namespace attributes to
  Regrtest attributes. Regrtest match_tests and ignore_tests
  attributes have type FilterTuple (tuple), instead of a list.
* Add RunTests.copy(). Regrtest._rerun_failed_tests() now uses
  RunTests.copy().
* Replace Regrtest.all_tests (list) with Regrtest.first_runtests
  (RunTests).
* Make random_seed maximum 10x larger (9 digits, instead of 8).
@vstinner vstinner added the skip news label Sep 8, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Sep 8, 2023
@vstinner
vstinner enabled auto-merge (squash) September 8, 2023 22:44
@bedevere-bot bedevere-bot mentioned this pull request Sep 8, 2023
Refactor test.libregrtest #109162
Closed
@vstinner
vstinner merged commit ac8409b into python:main Sep 8, 2023
@vstinner
vstinner deleted the regrtest_refactor2 branch September 8, 2023 23:48
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 8, 2023
@vstinner vstinner mentioned this pull request Sep 9, 2023
gh-108996: add tests for msvcrt #109004
Merged
@bedevere-bot

bedevere-bot commented Sep 9, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Non-Debug 3.x has failed when building commit ac8409b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/914/builds/2794) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac8409b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/914/builds/2794

Failed tests:

  • test.test_concurrent_futures.test_deadlock
  • test_msvcrt

Failed subtests:

  • test_kbhit - test.test_msvcrt.TestConsoleIO.test_kbhit
  • test_getwch - test.test_msvcrt.TestConsoleIO.test_getwch

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "b:\uildarea\3.x.ware-win11.nondebug\build\Lib\test\test_msvcrt.py", line 65, in test_kbhit
    self.assertEqual(msvcrt.kbhit(), 0)
AssertionError: 1 != 0


Traceback (most recent call last):
  File "b:\uildarea\3.x.ware-win11.nondebug\build\Lib\test\test_msvcrt.py", line 77, in test_getwch
    self.assertEqual(msvcrt.getwch(), c)
AssertionError: '\n' != '\u5b57'
+ \u5b57
- 
- 
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.