GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-109118: Fix runtime crash when NameError happens in PEP 695 function (GH-109123) by JelleZijlstra · Pull Request #109173 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Sep 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 17f9941)

  • Issue: Annotation scopes containing nested scopes #109118

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra added 2 commits September 8, 2023 20:22
@JelleZijlstra
pythongh-109118: Fix runtime crash when NameError happens in PEP 695 …
546f56d 
…function (python#109123)

(cherry picked from commit 17f9941)
@JelleZijlstra
[3.12] pythongh-109118: Fix runtime crash when NameError happens in P…
e28d114 
…EP 695 function (pythonGH-109123).

(cherry picked from commit 17f9941)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot bedevere-bot added the awaiting core review label Sep 9, 2023
This was referenced Sep 9, 2023
Annotation scopes containing nested scopes #109118
Closed
gh-109118: Fix runtime crash when NameError happens in PEP 695 function #109123
Merged
@JelleZijlstra JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Sep 9, 2023
@bedevere-bot

bedevere-bot commented Sep 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit e28d114 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Sep 9, 2023
@JelleZijlstra

JelleZijlstra commented Sep 9, 2023

Copy link
Copy Markdown
Member Author

I had to redo this from scratch because the code is so different on main, so running it through the buildbots again to make sure I got it right.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Sep 9, 2023

Copy link
Copy Markdown
Member Author

@Yhg1s this one is important to get into 3.12. The refleak buildbots are failing, but it's a refleak on test_import that also exists on the current 3.12 branch, so this should be good to go.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra assigned Yhg1s Sep 9, 2023
carljm
carljm approved these changes Sep 10, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 10, 2023
@Yhg1s
Yhg1s merged commit acde502 into python:3.12 Sep 12, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @bedevere-bot @carljm @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.