GeezerVison is showing github.com — gh-109162: Refactor libregrtest.Regrtest by vstinner · Pull Request #109206 · python/cpython
Conversation
vstinner
commented
Sep 10, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
-
Add type hint types: TestName, StrPath, StrJSON.
-
Add attributes to Regrtest:
- cmdline_args
- coverage
- coverage_dir
- fail_rerun
- next_single_filename
- print_slowest
- tmp_dir
- want_rerun
- want_run_leaks
-
Remove Regrtest.ns attribute.
-
Rename Regrtest methods:
- cleanup() => cleanup_temp_dir()
- create_temp_dir() => make_temp_dir()
- set_temp_dir() => select_temp_dir()
-
Convert Regrtest methods to static methods:
- cleanup_temp_dir()
- display_header()
- fix_umask()
- get_rerun_match_tests()
- list_tests()
- make_temp_dir()
- select_temp_dir()
-
Remove display_sanitizers() method: move code into display_header().
-
Rename 'test_cwd' variable to 'work_dir'.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
* Add type hint types: TestName, StrPath, StrJSON.
* Add attributes to Regrtest:
* cmdline_args
* coverage
* coverage_dir
* fail_rerun
* next_single_filename
* print_slowest
* tmp_dir
* want_rerun
* want_run_leaks
* Remove Regrtest.ns attribute.
* Rename Regrtest methods:
* cleanup() => cleanup_temp_dir()
* create_temp_dir() => make_temp_dir()
* set_temp_dir() => select_temp_dir()
* Convert Regrtest methods to static methods:
* cleanup_temp_dir()
* display_header()
* fix_umask()
* get_rerun_match_tests()
* list_tests()
* make_temp_dir()
* select_temp_dir()
* Remove display_sanitizers() method: move code into
display_header().
* Rename 'test_cwd' variable to 'work_dir'.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.