GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109162: libregrtest: add Logger class by vstinner · Pull Request #109212 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 10, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Add Logger class in a new logger.py file.

  • Move Regrtest attributes to Logger:

    • start_time
    • test_count_text
    • test_count_width
    • win_load_tracker
  • Move Regrtest method to Logger:

    • log()
    • getloadavg(): rename to get_load_avg()
    • set_tests()
  • Add methods to the Logger class:

    • start_load_tracker()
    • stop_load_tracker()
  • Issue: Refactor test.libregrtest #109162

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-109162: libregrtest: add Logger class
1e68f59
* Add Logger class in a new logger.py file.
* Move Regrtest attributes to Logger:

  * start_time
  * test_count_text
  * test_count_width
  * win_load_tracker

* Move Regrtest method to Logger:

  * log()
  * getloadavg(): rename to get_load_avg()
  * set_tests()

* Add methods to the Logger class:

  * start_load_tracker()
  * stop_load_tracker()
@vstinner vstinner added the skip news label Sep 10, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Sep 10, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 10, 2023
Refactor test.libregrtest #109162
Closed
@vstinner
vstinner enabled auto-merge (squash) September 10, 2023 02:35
@vstinner
vstinner merged commit 0eab242 into python:main Sep 10, 2023
@vstinner
vstinner deleted the regrtest_refactor12 branch September 10, 2023 03:04
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.