GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109162: libregrtest: move code around by vstinner · Pull Request #109253 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 11, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Move Regrtest.display_header() to utils.py.
  • Move cleanup_temp_dir() to utils.py.
  • Move list_cases() to findtests.py.
  • Issue: Refactor test.libregrtest #109162

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Sep 11, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Sep 11, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 11, 2023
Refactor test.libregrtest #109162
Closed
@vstinner
vstinner force-pushed the regrtest_refactor18 branch 2 times, most recently from 65c0bd3 to b374559 Compare September 11, 2023 07:54
@vstinner
vstinner enabled auto-merge (squash) September 11, 2023 07:55
@vstinner

vstinner commented Sep 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Strange, test_regrtest.test_huntrleaks() failed on Windows x64, but only test_huntrleaks(): test_huntrleaks_mp() passed for example whereas it's basically the same test run in a worker process.

  • expected: test_regrtest_huntrleaks leaked [1, 1, 1] references, sum=3
  • got: test_regrtest_huntrleaks leaked [1, 1, 9] references, sum=11

I don't know where these +8 references are coming from.

I suppose that it's random failures. Maybe related to an internal Python cache.

FAIL: test_huntrleaks (test.test_regrtest.ArgsTestCase.test_huntrleaks)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_regrtest.py", line 1060, in test_huntrleaks
    self.check_huntrleaks(multiprocessing=False)
  File "D:\a\cpython\cpython\Lib\test\test_regrtest.py", line 1057, in check_huntrleaks
    self.check_leak(code, 'references', multiprocessing=multiprocessing)
  File "D:\a\cpython\cpython\Lib\test\test_regrtest.py", line 1039, in check_leak
    self.assertIn(line2, output)
AssertionError: 'test_regrtest_huntrleaks leaked [1, 1, 1] references, sum=3\n' not found in '0:00:00 Run tests sequentially\n0:00:00 [1/1] test_regrtest_huntrleaks\nbeginning 9 repetitions\n123456789\n.........\ntest_regrtest_huntrleaks leaked [1, 1, 9] references, sum=11\ntest_regrtest_huntrleaks leaked [1, 1, 1] memory blocks, sum=3\ntest_regrtest_huntrleaks failed (reference leak)\n\n== Tests result: FAILURE ==\n\n1 test failed:\n    test_regrtest_huntrleaks\n\nTotal duration: 496 ms\nTotal tests: run=1\nTotal test files: run=1/1 failed=1\nResult: FAILURE\n'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 11, 2023

Copy link
Copy Markdown
Member Author

Strange, test_regrtest.test_huntrleaks() failed on Windows x64

I cannot reproduce the issue on Windows or Linux with ./python -m test -v test_regrtest -j1 --forever. The test passed 3-4 times on each OS (I didn't wait longer).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-109162: libregrtest: move code around
84249d3 
* Move Regrtest.display_header() to utils.py.
* Move cleanup_temp_dir() to utils.py.
* Move list_cases() to findtests.py.
@vstinner
vstinner force-pushed the regrtest_refactor18 branch from b374559 to 84249d3 Compare September 11, 2023 08:28
@vstinner

vstinner commented Sep 11, 2023

Copy link
Copy Markdown
Member Author

I rebased my PR on main to get "gh-107219: Fix concurrent.futures terminate_broken() (#109244)" fix. test_concurrent_futures hanged twice on the Windows x64 job.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit c439f6a into python:main Sep 11, 2023
@vstinner
vstinner deleted the regrtest_refactor18 branch September 11, 2023 08:52
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.