GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-107219: Fix concurrent.futures terminate_broken() (GH-109244) by miss-islington · Pull Request #109254 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 11, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix a race condition in concurrent.futures. When a process in the
process pool was terminated abruptly (while the future was running or
pending), close the connection write end. If the call queue is
blocked on sending bytes to a worker process, closing the connection
write end interrupts the send, so the queue can be closed.

Changes:

  • _ExecutorManagerThread.terminate_broken() now closes
    call_queue._writer.
  • multiprocessing PipeConnection.close() now interrupts
    WaitForMultipleObjects() in _send_bytes() by cancelling the
    overlapped operation.
    (cherry picked from commit a9b1f84)

Co-authored-by: Victor Stinner [email protected]

  • Issue: test_concurrent_futures.test_deadlock: test_crash_big_data() hangs randomly on Windows #107219

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
pythongh-107219: Fix concurrent.futures terminate_broken() (pythonGH-…
34467dd 
…109244)

Fix a race condition in concurrent.futures. When a process in the
process pool was terminated abruptly (while the future was running or
pending), close the connection write end. If the call queue is
blocked on sending bytes to a worker process, closing the connection
write end interrupts the send, so the queue can be closed.

Changes:

* _ExecutorManagerThread.terminate_broken() now closes
  call_queue._writer.
* multiprocessing PipeConnection.close() now interrupts
  WaitForMultipleObjects() in _send_bytes() by cancelling the
  overlapped operation.
(cherry picked from commit a9b1f84)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Sep 11, 2023
This was referenced Sep 11, 2023
test_concurrent_futures.test_deadlock: test_crash_big_data() hangs randomly on Windows #107219
Closed
gh-107219: Fix concurrent.futures terminate_broken() #109244
Merged
vstinner
vstinner approved these changes Sep 11, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 11, 2023
gpshead
gpshead approved these changes Sep 12, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting merge labels Sep 12, 2023
@gpshead gpshead assigned Yhg1s Sep 12, 2023
@gpshead

gpshead commented Sep 12, 2023

Copy link
Copy Markdown
Member

I don't know that this strictly needs to hold up 3.12.0, it'd be fine in 3.12.1... but the issue this addresses seems to be one that causes CI testing to fail frequently on windows. so it might help unblock things anyways.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s

Yhg1s commented Sep 12, 2023

Copy link
Copy Markdown
Member

FYI, I'm delaying this until 3.12.1.
gpshead reacted with thumbs up emoji vstinner reacted with confused emoji
All reactions
  • 👍 1 reaction
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s
Yhg1s merged commit 1d8c18c into python:3.12 Oct 2, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 2, 2023
@miss-islington
miss-islington deleted the backport-a9b1f84-3.12 branch October 2, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gpshead @Yhg1s @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.