GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||
GeezerVison is showing github.com — [3.12] gh-60283: Check for redefined test names in CI (GH-109161) by miss-islington · Pull Request #109365 · python/cpython Conversation
|
|
The PR description doesn't seem accurate. Is this really a good idea for 3.12 (3.12.0 rc3 or 3.12.1)? Do we have a good handle on potential fallout from adding this workflow? Is the benefit of running on 3.12 worth the potential disruption? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
My opinion: I don't think it's crucial at all that this gets into 3.12.0; I'd certainly be fine with it being delayed until 3.12.1. However, I don't see it as a particularly risky change, so I also don't think there'd be any harm in it going into 3.12.0. What this PR doesIt adds a workflow that runs ruff in CI on Why adding this CI check is usefulThis is useful for CPython, in that it means that the rule detects Why I think it's good to backport this PR to 3.12 (but not necessarily 3.12.0)We've had lots of situations in the past where core developers have been pretty confused due to CI setups being subtly different between the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.