GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-105658: fix excess trace events for except block ending with a conditional block (#109384) by iritkatriel · Pull Request #109411 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Sep 14, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 4a54074)

  • Issue: 3.12 tracing regression: a conditional in a finally block will revisit the condition before exiting the block. #105658

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-105658: fix excess trace events for except block ending with…
180fcd4 
… a conditional block (python#109384)

(cherry picked from commit 4a54074)
@iritkatriel
iritkatriel requested a review from markshannon as a code owner September 14, 2023 16:28
@bedevere-app bedevere-app Bot added the awaiting review label Sep 14, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 14, 2023
3.12 tracing regression: a conditional in a finally block will revisit the condition before exiting the block. #105658
Closed
@iritkatriel
iritkatriel requested a review from carljm September 14, 2023 16:28
@iritkatriel iritkatriel changed the title gh-105658: fix excess trace events for except block ending with a conditional block (#109384) [3.12] gh-105658: fix excess trace events for except block ending with a conditional block (#109384) Sep 14, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 14, 2023
gh-105658: fix excess trace events for except block ending with a conditional block #109384
Merged
@bedevere-app bedevere-app Bot added the type-bug An unexpected behavior, bug, or error label Sep 14, 2023
@iritkatriel iritkatriel assigned Yhg1s Sep 14, 2023
carljm
carljm approved these changes Sep 14, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 14, 2023
@Yhg1s
Yhg1s merged commit 3eae45f into python:3.12 Sep 14, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @carljm @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.