GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-108822: Fix regrtest clear_caches() by vstinner · Pull Request #109432 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 14, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Python 3.11 doesn't have fractions._hash_algorithm cache.

  • Issue: regrtest: compute statistics on executed tests #108822

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-108822: Fix regrtest clear_caches()
feaac85
Python 3.11 doesn't have fractions._hash_algorithm cache.
@vstinner vstinner added the skip news label Sep 14, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Sep 14, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 14, 2023
regrtest: compute statistics on executed tests #108822
Closed
@vstinner

vstinner commented Sep 14, 2023

Copy link
Copy Markdown
Member Author

Without this change, ./python -m test test_buffer -R 3:3 fails with:

test test_buffer crashed -- Traceback (most recent call last):
  File "/home/vstinner/python/3.11/Lib/test/libregrtest/runtest.py", line 391, in _runtest_env_changed_exc
    _load_run_test(result, ns)
  File "/home/vstinner/python/3.11/Lib/test/libregrtest/runtest.py", line 351, in _load_run_test
    regrtest_runner(result, test_func, ns)
  File "/home/vstinner/python/3.11/Lib/test/libregrtest/runtest.py", line 306, in regrtest_runner
    refleak, test_result = dash_R(ns, result.test_name, test_func)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vstinner/python/3.11/Lib/test/libregrtest/refleak.py", line 87, in dash_R
    dash_R_cleanup(fs, ps, pic, zdc, abcs)
  File "/home/vstinner/python/3.11/Lib/test/libregrtest/refleak.py", line 182, in dash_R_cleanup
    clear_caches()
  File "/home/vstinner/python/3.11/Lib/test/libregrtest/utils.py", line 220, in clear_caches
    fractions._hash_algorithm.cache_clear()
    ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'fractions' has no attribute '_hash_algorithm'

test_buffer failed (uncaught exception)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner enabled auto-merge (squash) September 14, 2023 23:44
@vstinner
vstinner merged commit 7a20797 into python:3.11 Sep 15, 2023
@vstinner
vstinner deleted the regrtest_refleak_311 branch September 15, 2023 00:07
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.