GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-109496: Skip test_capi.test_decref_freed_object() on ASAN (GH-109573) by miss-islington · Pull Request #109578 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 19, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Skip test_decref_freed_object() of test_capi.test_misc if Python is
built with ASAN, MSAN or UBSAN sanitizers.
(cherry picked from commit 0a31ff0)

Co-authored-by: Victor Stinner [email protected]

  • Issue: Calling Py_DECREF twice does not result in error with debug build #109496

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner @miss-islington
pythongh-109496: Skip test_capi.test_decref_freed_object() on ASAN (p…
d5744a4
…ythonGH-109573)

Skip test_decref_freed_object() of test_capi.test_misc if Python is
built with ASAN, MSAN or UBSAN sanitizers.
(cherry picked from commit 0a31ff0)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 19, 2023
This was referenced Sep 19, 2023
Calling Py_DECREF twice does not result in error with debug build #109496
Closed
gh-109496: Skip test_capi.test_decref_freed_object() on ASAN #109573
Merged
@bedevere-app bedevere-app Bot added the skip news label Sep 19, 2023
vstinner
vstinner approved these changes Sep 19, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 19, 2023
@pablogsal
pablogsal merged commit 62d9ae4 into python:3.12 Oct 2, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 2, 2023
@miss-islington
miss-islington deleted the backport-0a31ff0-3.12 branch October 2, 2023 14:09
@pablogsal

pablogsal commented Oct 2, 2023

Copy link
Copy Markdown
Member

@vstinner Now approving doesn't autoland, you need to check the "Auto Land" button

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba

zooba commented Oct 2, 2023

Copy link
Copy Markdown
Member

@pablogsal FYI, auto-merge buttons don't appear for us plebs when the branch is locked.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Oct 2, 2023

Copy link
Copy Markdown
Member

@vstinner Now approving doesn't autoland, you need to check the "Auto Land" button

I approved my own backports to give some trust to the person who is going to merge it manually, since the 3.12 branch was blocked for a few days, and backports were done manually.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @pablogsal @zooba @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.