GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-108303: Create Lib/test/test_dataclasses/ directory (GH-108978) by miss-islington · Pull Request #109674 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 21, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Move test_dataclasses.py and its "dataclass_*.py" modules into the
new Lib/test/test_dataclasses/ subdirectory.
(cherry picked from commit 14d6e19)

Co-authored-by: Victor Stinner [email protected]

  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
pythongh-108303: Create Lib/test/test_dataclasses/ directory (pythonG…
16afb36 
…H-108978)

Move test_dataclasses.py and its "dataclass_*.py" modules into the
new Lib/test/test_dataclasses/ subdirectory.
(cherry picked from commit 14d6e19)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington
miss-islington requested a review from ericvsmith as a code owner September 21, 2023 17:54
@bedevere-app bedevere-app Bot added the awaiting review label Sep 21, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 21, 2023
Move test files into test subdirectories #108303
Closed
@bedevere-app bedevere-app Bot added the skip news label Sep 21, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 21, 2023
gh-108303: Create Lib/test/test_dataclasses/ directory #108978
Merged
vstinner
vstinner approved these changes Sep 21, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot 🤖.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 21, 2023
@vstinner
Fix Lint job: update Lib/test/.ruff.toml
6ac9e9b
@vstinner
vstinner requested review from AlexWaygood and hugovk as code owners September 21, 2023 18:12
@vstinner

vstinner commented Sep 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Oh, the Lint job failed, I updated Lib/test/.ruff.toml.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Sep 21, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot 🤖.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood AlexWaygood assigned Yhg1s Sep 21, 2023
@Yhg1s
Yhg1s merged commit 9bceb8a into python:3.12 Oct 2, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 2, 2023
@miss-islington
miss-islington deleted the backport-14d6e19-3.12 branch October 2, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @vstinner @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.