GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697) by vstinner · Pull Request #109698 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 21, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

(cherry picked from commit 26e06ad)

  • Issue: tarfile doesn't set file modes correctly on FreeBSD: test_tarfile.test_modes() fails on FreeBSD #108948

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pyth…
71a615d 
…on#109697)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

(cherry picked from commit 26e06ad)
@vstinner
vstinner requested a review from ethanfurman as a code owner September 21, 2023 23:02
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 21, 2023
@vstinner vstinner added skip news and removed tests Tests in the Lib/test dir awaiting review labels Sep 21, 2023
This was referenced Sep 21, 2023
tarfile doesn't set file modes correctly on FreeBSD: test_tarfile.test_modes() fails on FreeBSD #108948
Closed
gh-108948: Skip test_tarfile.test_modes() on EFTYPE error #109697
Merged
@vstinner

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

!buildbot AMD64 FreeBSD
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Sep 21, 2023

Copy link
Copy Markdown

The regex {builder_filter!r} did not match any buildbot builder
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Sep 21, 2023
Close #390: Ignore !buildbot comment if no builder matches python/buildmaster-config#400
Merged
@vstinner

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

The regex {builder_filter!r} did not match any buildbot builder

I knew it in advance :-) It was just to test my fix python/buildmaster-config#390 :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

I tested this change manually on my FreeBSD VM: it works as expected.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Sep 22, 2023

Copy link
Copy Markdown
Member

@vstinner seems like there's a missing f on an f-string in the previous message from Bedevere, do you know if that's already fixed or tracked?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Sep 22, 2023

Copy link
Copy Markdown
Member

Ah, seems like python/buildmaster-config@69e9ee1 fixed it.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 24, 2023

Copy link
Copy Markdown
Member Author

!buildbot AMD64 FreeBSD
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Sep 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 71a615d 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD

The builders matched are:

  • AMD64 FreeBSD PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 24, 2023

Copy link
Copy Markdown
Member Author

AMD64 FreeBSD buildbot joined the club of STABLE buildbots and so can now used on GitHub PRs with !buildbot AMD64 FreeBSD comment!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 25, 2023

Copy link
Copy Markdown
Member Author

buildbot/AMD64 FreeBSD PR — Build done.

Good, tests pass.

Total test files: run=479/483 skipped=16 resource_denied=4
Result: SUCCESS

Currently, FreeBSD 3.12 buildbot fails because of test_tarfile: https://buildbot.python.org/all/#/builders/1220
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s
Yhg1s merged commit 84ef145 into python:3.12 Oct 2, 2023
@vstinner
vstinner deleted the test_tarfile_modes_312 branch January 14, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @bedevere-bot @JelleZijlstra @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.