GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — WIP: Always pass errno argument for OSError subclasses by serhiy-storchaka · Pull Request #109720 · python/cpython Conversation
Member
It solves #109601, but covers not only TimeoutError, but other OSError subclasses. With #109714 these changes will be unneeded (except that some calls may be improved to set filename), because errno and strerror will be set automatically. This PR is a demonstration of changes when do it explicitly. #109714 be accepted and we decide to apply these changes to older versions, this PR will be converted in a backport PR.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. # Conflicts: # Lib/asyncio/tasks.py # Lib/asyncio/timeouts.py # Lib/importlib/resources/abc.py # Lib/importlib/resources/readers.py # Lib/importlib/resources/simple.py # Lib/multiprocessing/pool.py # Lib/socket.py # Lib/zipfile/_path/__init__.py Concrete OSError subclasses raised in the stdlib often carried no errno at all, so exc.errno was None and str(exc) lacked the usual "[Errno N]" prefix. Pass an appropriate errno (and a filename where one is available) everywhere such an exception is raised. In C code, PyErr_SetString() with an OSError subclass has the same problem. Add _PyErr_SetOSErrorWithMessage(), which builds the (errno, msg) pair, and use it in sys.remote_exec(), _io.TextIOWrapper.read(), _interpchannels and _Py_RemoteDebug_WriteRemoteMemory(). In _ssl the existing set_timeout_err() helper covers the remaining sites. turtle.TurtleScreen.save() now passes the offending path as the filename argument instead of embedding it in the message, so its errors gain the "[Errno N] ...: 'path'" form. test_turtle and the as_completed() timeout test are updated for the new messages. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |