GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-106584: Fix exit code for unittest in Python 3.12 (GH-106588) by miss-islington · Pull Request #109725 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 22, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 8fc0713)

Co-authored-by: EliseevEgor [email protected]
Co-authored-by: sunmy2019 [email protected]
Co-authored-by: Nikita Sobolev [email protected]

  • Issue: Return the correct exit code if all tests have been skipped in unittest #106584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EliseevEgor @sunmy2019
@sobolevn @miss-islington
pythongh-106584: Fix exit code for unittest in Python 3.12 (pythonGH-…
95fcc0d 
…106588)

(cherry picked from commit 8fc0713)

Co-authored-by: EliseevEgor <[email protected]>
Co-authored-by: sunmy2019 <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Sep 22, 2023
This was referenced Sep 22, 2023
Return the correct exit code if all tests have been skipped in unittest #106584
Closed
gh-106584: Fix exit code for unittest in Python 3.12 #106588
Merged
@ambv

ambv commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

This is a bug in 3.12.0, the fix should land for 3.12.1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s
Yhg1s merged commit 551aa6a into python:3.12 Oct 2, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 2, 2023
@miss-islington
miss-islington deleted the backport-8fc0713-3.12 branch October 2, 2023 15:18
@sodul sodul mentioned this pull request Dec 12, 2023
stopTest issue with Python 3.12.1 and skipped tests CleanCut/green#277
Closed
@sodul

sodul commented Dec 12, 2023

Copy link
Copy Markdown

@miss-islington, @ambv I suspect this change is breaking green on skipped tests: CleanCut/green#277

Green is tracking test duration by setting a time when startTest is called then calculates the duration in stopTest, unfortunately the changes here are now skipping startTest but not stopTest, if I read the changes correctly.

I will work with the green maintainer to update green to be compatible. There is no issue if no tests are skipped.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @ambv @sodul @Yhg1s @EliseevEgor
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.