GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-101100: Fix Sphinx warnings in Doc/using/configure.rst (GH-109931) by miss-islington · Pull Request #109937 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 27, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 3538930)

Co-authored-by: Victor Stinner [email protected]

  • Issue: Fix all Sphinx reference warnings in the documentation #101100

📚 Documentation preview 📚: https://cpython-previews--109937.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner @miss-islington
pythongh-101100: Fix Sphinx warnings in Doc/using/configure.rst (pyth…
e1de39b
…onGH-109931)

(cherry picked from commit 3538930)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington
miss-islington requested review from corona10 and erlend-aasland as code owners September 27, 2023 00:01
@bedevere-app bedevere-app Bot added the awaiting review label Sep 27, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2023
Fix all Sphinx reference warnings in the documentation #101100
Closed
@bedevere-app bedevere-app Bot added the skip news label Sep 27, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2023
gh-101100: Fix Sphinx warnings in Doc/using/configure.rst #109931
Merged
vstinner
vstinner approved these changes Sep 27, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 27, 2023
@erlend-aasland

erlend-aasland commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

This breaks the Docs CI:

Error: must not contain warnings:

Doc/using/configure.rst
  772: c:macro reference target not found: PyAPI_FUNC()
  772: c:macro reference target not found: PyAPI_DATA()
  772: c:macro reference target not found: PyMODINIT_FUNC
Error: Process completed with exit code 255.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Sep 27, 2023

Copy link
Copy Markdown
Member

This breaks the Docs CI:
772: c:macro reference target not found: PyAPI_FUNC()
772: c:macro reference target not found: PyAPI_DATA()
772: c:macro reference target not found: PyMODINIT_FUNC

Oh, I forgot to backport other Sphinx warnings fixed: PR #109236. I just created PR #109947 for Python 3.12: it should be merged before this PR.

erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

Great, thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Yhg1s
Merge branch '3.12' into backport-3538930-3.12
b791fae
@Yhg1s
Yhg1s merged commit 60046a7 into python:3.12 Sep 28, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 28, 2023
@miss-islington
miss-islington deleted the backport-3538930-3.12 branch September 28, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @erlend-aasland @vstinner @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.