GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-109615: Fix support test_copy_python_src_ignore() (#109958) by vstinner · Pull Request #110340 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 4, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test_tools: test_freeze_simple_script() fails on s390x SLES 3.x: [Errno 2] No such file or directory: (...) #109615

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
vstinner and others added 4 commits October 4, 2023 11:49
@vstinner
pythongh-109615: Fix support test_copy_python_src_ignore() (python#10…
b24ecb7
…9958)

Fix the test when run on an installed Python: use "abs_srcdir" of
sysconfig, and skip the test if the Python source code cannot be
found.

* Tools/patchcheck/patchcheck.py, Tools/freeze/test/freeze.py and
  Lib/test/libregrtest/utils.py now first try to get "abs_srcdir"
  from sysconfig, before getting "srcdir" from sysconfig.
* test.pythoninfo logs sysconfig "abs_srcdir".

(cherry picked from commit b89ed9d)
@vstinner
pythongh-109615: Fix support test_copy_python_src_ignore() on WASM (p…
c310ecb
…ython#109970)

Not only check if src_dir exists, but look also for Lib/os.py
landmark.

(cherry picked from commit cc54bcf)
@zooba @vstinner
pythongh-109615: Look for 'Modules' as landmark for test_copy_python_…
4f4c799
…src_ignore (pythonGH-110108)

(cherry picked from commit 20bc5f7)
@vstinner
pythongh-109748: Fix again venv test_zippath_from_non_installed_posix…
a334057
…() (python#110149)

Call also copy_python_src_ignore() on listdir() names.

shutil.copytree(): replace set() with an empty tuple. An empty tuple
becomes a constant in the compiler and checking if an item is in an
empty tuple is cheap.

(cherry picked from commit 0def8c7)
@vstinner
vstinner requested a review from vsajip as a code owner October 4, 2023 09:54
@bedevere-app bedevere-app Bot added the awaiting review label Oct 4, 2023
This was referenced Oct 4, 2023
test_tools: test_freeze_simple_script() fails on s390x SLES 3.x: [Errno 2] No such file or directory: (...) #109615
Closed
gh-109615: Fix support test_copy_python_src_ignore() #109958
Merged
@bedevere-app bedevere-app Bot added the skip news label Oct 4, 2023
@vstinner
vstinner enabled auto-merge (squash) October 4, 2023 09:56
@vstinner
vstinner merged commit 8939221 into python:3.12 Oct 4, 2023
@vstinner
vstinner deleted the copy_src32 branch October 4, 2023 10:27
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.