GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-109408: Move the C file whitespace check from patchcheck to pre-commit (GH-109890) by AA-Turner · Pull Request #110640 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Oct 10, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit f5edb56)

  • Issue: Move Azure Pipelines CI to GitHub Actions #109408

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
[3.11] pythonGH-109408: Move the C file whitespace check from patchch…
fd8ddd4 
…eck to pre-commit (pythonGH-109890)

Co-authored-by: Hugo van Kemenade <[email protected]>.
(cherry picked from commit f5edb56)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Oct 10, 2023
GH-109408: Move the C file whitespace check from patchcheck to pre-commit #109890
Merged
@bedevere-app bedevere-app Bot added the skip news label Oct 10, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 10, 2023
Move Azure Pipelines CI to GitHub Actions #109408
Closed
@AA-Turner

AA-Turner commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

To be merged following #110641.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
fix the directory
afd9d76
@AA-Turner

AA-Turner commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

Both this PR and #110641 are failing due to valid lint failures -- (in Tools/c-analyzer/cpython/_capi.py and Modules/_ctypes/darwin/dlfcn.h). We could add exclusions for these files, or perhaps just not backport? Unsure how best to proceed.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Oct 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Both this PR and #110641 are failing due to valid lint failures -- (in Tools/c-analyzer/cpython/_capi.py and Modules/_ctypes/darwin/dlfcn.h). We could add exclusions for these files, or perhaps just not backport? Unsure how best to proceed.

A

Adding excludes (or fixing the failures) seems like a good idea to me. It's useful to keep CI stuff in sync for all the maintenance branches.

Having said that, if there's loads of stuff that needs changing, I wouldn't bother -- it's not the end of the world if it's not backported!
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Fix excludes
707ffaa
@AlexWaygood

AlexWaygood commented Oct 11, 2023

Copy link
Copy Markdown
Member

Thanks! Closing for now, though, since the PR to main was reverted
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood closed this Oct 11, 2023
@AA-Turner
AA-Turner deleted the backport-f5edb56-3.11 branch January 13, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk Awaiting requested review from hugovk hugovk will be requested when the pull request is marked ready for review hugovk is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AA-Turner @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.